You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rivet-dev@tcl.apache.org by mx...@apache.org on 2010/04/20 00:10:07 UTC

svn commit: r935759 - in /tcl/rivet/trunk: ChangeLog tests/upload.rvt tests/upload.test

Author: mxmanghi
Date: Mon Apr 19 22:10:07 2010
New Revision: 935759

URL: http://svn.apache.org/viewvc?rev=935759&view=rev
Log:
    * tests/upload.[rvt|test]: fix upload message sent to server. The end boundary
	went undetected and Rivet added it to the uploaded file. Thus the problem
	affected only the test, not the module. Added delimiter to the returned 
	message to allow easy spotting of an empty string.


Modified:
    tcl/rivet/trunk/ChangeLog
    tcl/rivet/trunk/tests/upload.rvt
    tcl/rivet/trunk/tests/upload.test

Modified: tcl/rivet/trunk/ChangeLog
URL: http://svn.apache.org/viewvc/tcl/rivet/trunk/ChangeLog?rev=935759&r1=935758&r2=935759&view=diff
==============================================================================
--- tcl/rivet/trunk/ChangeLog (original)
+++ tcl/rivet/trunk/ChangeLog Mon Apr 19 22:10:07 2010
@@ -1,3 +1,9 @@
+2010-04-19 Massimo Manghi <mx...@apache.org>
+    * tests/upload.[rvt|test]: fix upload message sent to server. The end boundary
+	went undetected and Rivet added it to the uploaded file. Thus the problem
+	affected only the test, not the module. Added delimiter to the returned 
+	message to allow easy spotting of an empty string.
+
 2009-12-08 Karl Lehenbauer <ka...@apache.org>
     * rivet/packages/form/form.tcl, form.txt: Add new form methods for HTML 5
       form elements "color", "date", "datetime", "datetime_local", "email",

Modified: tcl/rivet/trunk/tests/upload.rvt
URL: http://svn.apache.org/viewvc/tcl/rivet/trunk/tests/upload.rvt?rev=935759&r1=935758&r2=935759&view=diff
==============================================================================
--- tcl/rivet/trunk/tests/upload.rvt (original)
+++ tcl/rivet/trunk/tests/upload.rvt Mon Apr 19 22:10:07 2010
@@ -1,5 +1,2 @@
-<?
+<? puts "[upload names] [upload exists uploadtest] [upload size uploadtest] -[upload type uploadtest]- [upload filename uploadtest]" ?>
 
-puts "[upload names] [upload exists uploadtest] [upload size uploadtest] [upload type uploadtest] [upload filename uploadtest]"
-
-?>
\ No newline at end of file

Modified: tcl/rivet/trunk/tests/upload.test
URL: http://svn.apache.org/viewvc/tcl/rivet/trunk/tests/upload.test?rev=935759&r1=935758&r2=935759&view=diff
==============================================================================
--- tcl/rivet/trunk/tests/upload.test (original)
+++ tcl/rivet/trunk/tests/upload.test Mon Apr 19 22:10:07 2010
@@ -9,7 +9,7 @@ set testfilename1 upload.rvt
     set data [read $fl]
     close $fl
 
-    set outputData "--$bound\r\nContent-Disposition: form-data; name=\"uploadtest\"; filename=\"AngeloFish.jpg\"\r\n\r\n$data\n${bound}--"
+    set outputData "--$bound\r\nContent-Disposition: form-data; name=\"uploadtest\"; filename=\"AngeloFish.jpg\"\r\n\r\n$data\n--${bound}--"
 
     set page [::http::geturl "${urlbase}$testfilename1" \
 		  -type "multipart/form-data; boundary=$bound" -query $outputData]
@@ -17,7 +17,7 @@ set testfilename1 upload.rvt
     set ret [string trim [::http::data $page]]
     ::http::cleanup $page
     set ret
-} {uploadtest 1 42747  AngeloFish.jpg}
+} {uploadtest 1 42747 -- AngeloFish.jpg}
 
 set testfilename1 uploadsave.rvt
 
@@ -29,7 +29,7 @@ set testfilename1 uploadsave.rvt
     set data [read $fl]
     close $fl
 
-    set outputData "--$bound\r\nContent-Disposition: form-data; name=\"uploadtest\"; filename=\"AngeloFish.jpg\"\r\n\r\n$data\n${bound}--"
+    set outputData "--$bound\r\nContent-Disposition: form-data; name=\"uploadtest\"; filename=\"AngeloFish.jpg\"\r\n\r\n$data\n--${bound}--"
 
     set page [::http::geturl "${urlbase}$testfilename1" \
 		  -type "multipart/form-data; boundary=$bound" -query $outputData]



---------------------------------------------------------------------
To unsubscribe, e-mail: rivet-cvs-unsubscribe@tcl.apache.org
For additional commands, e-mail: rivet-cvs-help@tcl.apache.org