[GitHub] [buildstream] gtristan opened a new pull request #1518: Hardening API surfaces

[GitBox <gi...@apache.org>]

gtristan opened a new pull request #1518:
URL: https://github.com/apache/buildstream/pull/1518


   This branch comes after a review of the main API surfaces and addresses the following issues:
   
   * Type annotations for lists, i.e. #1388 - after review it seems mostly everything is fine, except now we pass an `Iterable` instead of a `List` to `Element.configure_dependencies()` so that we have more freedom to change the type in the future
   * `Plugin.call()` and `Plugin.check_output()` were blindly passing along keyword arguments to `subprocess.Popen()`, now we have a strongly defined API for these.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [buildstream] gtristan merged pull request #1518: Hardening API surfaces

[GitBox <gi...@apache.org>]

gtristan merged pull request #1518:
URL: https://github.com/apache/buildstream/pull/1518


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org