You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "johan rydberg (Created) (JIRA)" <ji...@apache.org> on 2012/03/23 08:12:22 UTC

[jira] [Created] (ZOOKEEPER-1431) zkpython: aget is leaking memory

zkpython: aget is leaking memory
--------------------------------

                 Key: ZOOKEEPER-1431
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
             Project: ZooKeeper
          Issue Type: Bug
          Components: contrib-bindings
    Affects Versions: 3.3.3
         Environment: RHEL 6.0, self-built from 3.3.3 sources
            Reporter: johan rydberg


I'm seeing a memory leakage when using the "aget" method.

It leaks tuples and dicts, both containing "stats".



--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1431) zkpython: aget is leaking memory

Posted by "Kapil Thangavelu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kapil Thangavelu updated ZOOKEEPER-1431:
----------------------------------------

    Attachment: pyzk-mem-leak-fix.diff

Fix for async python api memory leaks.
                
> zkpython: aget is leaking memory
> --------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.3.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>         Attachments: pyzk-mem-leak-fix.diff, zktest3.py, zktest4.py
>
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1431) zkpython: aget is leaking memory

Posted by "johan rydberg (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236430#comment-13236430 ] 

johan rydberg commented on ZOOKEEPER-1431:
------------------------------------------

https://github.com/apache/zookeeper/blob/trunk/src/contrib/zkpython/src/c/zookeeper.c#L487

Shouldn't arglist be decref'ed after the call?

That drops my tuple count from ~55k to ~5k after a zktest3.py run.

                
> zkpython: aget is leaking memory
> --------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.3.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>         Attachments: zktest3.py, zktest4.py
>
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "Kapil Thangavelu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236814#comment-13236814 ] 

Kapil Thangavelu commented on ZOOKEEPER-1431:
---------------------------------------------

Also wanted to note fwiw, we're going to apply the patch i attached to this issue, in the zookeeper 3.3.5 pkg distributed in ubuntu 12.04/precise.
                
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.3.3, 3.4.3, 3.3.5
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>         Attachments: pyzk-mem-leak-fix.diff, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "Kapil Thangavelu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kapil Thangavelu updated ZOOKEEPER-1431:
----------------------------------------

     Affects Version/s: 3.4.3
                        3.3.5
    Remaining Estimate: 1h
     Original Estimate: 1h
    
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.3.3, 3.4.3, 3.3.5
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>         Attachments: pyzk-mem-leak-fix.diff, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396393#comment-13396393 ] 

Henry Robinson commented on ZOOKEEPER-1431:
-------------------------------------------

Patch looks good, I'll commit shortly.
                
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.4.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>            Assignee: Kapil Thangavelu
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: pyzk-mem-leak-fix.diff, zk.patch, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt reassigned ZOOKEEPER-1431:
---------------------------------------

    Assignee: Kapil Thangavelu
    
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.3.3, 3.4.3, 3.3.5
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>            Assignee: Kapil Thangavelu
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: pyzk-mem-leak-fix.diff, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "André Cruz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295197#comment-13295197 ] 

André Cruz commented on ZOOKEEPER-1431:
---------------------------------------

I would also like to know. Tests were not included because it's not easy to test for a memory leak.
                
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.4.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>            Assignee: Kapil Thangavelu
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: pyzk-mem-leak-fix.diff, zk.patch, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396676#comment-13396676 ] 

Hudson commented on ZOOKEEPER-1431:
-----------------------------------

Integrated in ZooKeeper-trunk #1590 (See [https://builds.apache.org/job/ZooKeeper-trunk/1590/])
    ZOOKEEPER-1431. zkpython async calls leak memory (Kapil Thangavelu and Andre Cruz via henryr) (Revision 1351541)

     Result = SUCCESS
henry : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1351541
Files : 
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/contrib/zkpython/src/c/zookeeper.c

                
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.4.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>            Assignee: Kapil Thangavelu
>             Fix For: 3.3.6, 3.4.4, 3.5.0
>
>         Attachments: pyzk-mem-leak-fix.diff, zk.patch, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1431) zkpython: aget is leaking memory

Posted by "Kapil Thangavelu (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236804#comment-13236804 ] 

Kapil Thangavelu commented on ZOOKEEPER-1431:
---------------------------------------------

This bug applies to ALL async api calls with python.
                
> zkpython: aget is leaking memory
> --------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.3.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>         Attachments: zktest3.py, zktest4.py
>
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272368#comment-13272368 ] 

Hadoop QA commented on ZOOKEEPER-1431:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12526345/zk.patch
  against trunk revision 1336467.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1070//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1070//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1070//console

This message is automatically generated.
                
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.4.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>            Assignee: Kapil Thangavelu
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: pyzk-mem-leak-fix.diff, zk.patch, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "Kapil Thangavelu (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kapil Thangavelu updated ZOOKEEPER-1431:
----------------------------------------

    Summary: zkpython: async calls leak memory  (was: zkpython: aget is leaking memory)

Noting the problem is generic, it also applies to all extant versions 3.3x and 3.4
                
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.3.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>         Attachments: pyzk-mem-leak-fix.diff, zktest3.py, zktest4.py
>
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "Paul Giannaros (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279813#comment-13279813 ] 

Paul Giannaros commented on ZOOKEEPER-1431:
-------------------------------------------

Is this patch going to be applied soon? Are you waiting for justification on why it doesn't include new tests?
                
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.4.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>            Assignee: Kapil Thangavelu
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: pyzk-mem-leak-fix.diff, zk.patch, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1431) zkpython: aget is leaking memory

Posted by "johan rydberg (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

johan rydberg updated ZOOKEEPER-1431:
-------------------------------------

    Attachment: zktest4.py
                zktest3.py

Here's two test cases reproducing the error.

Both use pykeeper (ease_install pykeeper) to set things up, but then use the zkpython bindings to do the actual testing.

zktest3.py leaks, zktest4.py does not.

                
> zkpython: aget is leaking memory
> --------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.3.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>         Attachments: zktest3.py, zktest4.py
>
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "André Cruz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

André Cruz updated ZOOKEEPER-1431:
----------------------------------

    Attachment: zk.patch
    
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.4.3
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>            Assignee: Kapil Thangavelu
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: pyzk-mem-leak-fix.diff, zk.patch, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] [Commented] (ZOOKEEPER-1431) zkpython: async calls leak memory

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13262242#comment-13262242 ] 

Hadoop QA commented on ZOOKEEPER-1431:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12519666/pyzk-mem-leak-fix.diff
  against trunk revision 1330043.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1050//console

This message is automatically generated.
                
> zkpython: async calls leak memory
> ---------------------------------
>
>                 Key: ZOOKEEPER-1431
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1431
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib-bindings
>    Affects Versions: 3.3.3, 3.4.3, 3.3.5
>         Environment: RHEL 6.0, self-built from 3.3.3 sources
>            Reporter: johan rydberg
>            Assignee: Kapil Thangavelu
>             Fix For: 3.4.4, 3.5.0
>
>         Attachments: pyzk-mem-leak-fix.diff, zktest3.py, zktest4.py
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I'm seeing a memory leakage when using the "aget" method.
> It leaks tuples and dicts, both containing "stats".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira