[GitHub] [incubator-doris] morningman commented on issue #1045: feature: Add FE/BE auto deploy script

[GitBox <gi...@apache.org>]

morningman commented on issue #1045: feature: Add FE/BE auto deploy script
URL: https://github.com/apache/incubator-doris/issues/1045#issuecomment-487060005
 
 
   First, I am very thanks to you that you can contribute a deploy script for Doris.
   But I have to point out some problems of the script you provide.
   
   1. There is a `DeployManager.java` in FE source code. This is a base class for the deployment of Doris for some certain scenarios, such k8s, Ambari. And the derived class `LocalFileDeployManager` is for generic scenarios. I think you may use this to implement the deploy method.
   
   2. In my opinion, the deployment tools should contains the ability of downloading, distribution, installation and starting. And your scripts only implement the latter two, the downloading and distribution ability is missing.
   
   3. The expansibility and maintainability should also be considered. For example, what if user wants to add some additional configurations to `fe.conf` or `be.conf`? Is there a convenient way to change the configuration and re-deploy them again? And the latest `start_xx.sh` is added a new parameter `--daemon` instead of the `&` symbol, you'd better redesign the script.
   
   I think this script is not ready for now. But Doris DO long for a deployment toolset.
   Any idea can be discussed here (Using Chinese is also welcome).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org