You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/09 20:15:36 UTC

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11218: fix: update table_name and schema on dataset editor

codecov-io edited a comment on pull request #11218:
URL: https://github.com/apache/incubator-superset/pull/11218#issuecomment-706379744


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11218?src=pr&el=h1) Report
   > Merging [#11218](https://codecov.io/gh/apache/incubator-superset/pull/11218?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/56d5e8a1cb62f668f23e12f60d10f60ff82a7378?el=desc) will **decrease** coverage by `3.23%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11218/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11218?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11218      +/-   ##
   ==========================================
   - Coverage   65.53%   62.29%   -3.24%     
   ==========================================
     Files         828      436     -392     
     Lines       39148    14608   -24540     
     Branches     3589     3588       -1     
   ==========================================
   - Hits        25655     9100   -16555     
   + Misses      13381     5328    -8053     
   - Partials      112      180      +68     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.29% <50.00%> (-0.01%)` | :arrow_down: |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11218?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...perset-frontend/src/datasource/DatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `74.00% <50.00%> (ø)` | |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | | |
   | [...ions/versions/4500485bde7d\_allow\_run\_sync\_async.py](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy80NTAwNDg1YmRlN2RfYWxsb3dfcnVuX3N5bmNfYXN5bmMucHk=) | | |
   | [superset/tasks/alerts/observer.py](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvYWxlcnRzL29ic2VydmVyLnB5) | | |
   | [superset/datasets/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvZGFvLnB5) | | |
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvU3FsTGFiL2NvbXBvbmVudHMvUXVlcnlTZWFyY2guanN4) | | |
   | [...dashboard/util/logging/findTopLevelComponentIds.js](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvZGFzaGJvYXJkL3V0aWwvbG9nZ2luZy9maW5kVG9wTGV2ZWxDb21wb25lbnRJZHMuanM=) | | |
   | [superset/tasks/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | | |
   | [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-L2hvbWUvcnVubmVyL3dvcmsvaW5jdWJhdG9yLXN1cGVyc2V0L2luY3ViYXRvci1zdXBlcnNldC9zdXBlcnNldC1mcm9udGVuZC9zcmMvdmlld3MvQ1JVRC9kYXRhL2RhdGFzZXQvQWRkRGF0YXNldE1vZGFsLnRzeA==) | | |
   | [superset/css\_templates/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9kYW8ucHk=) | | |
   | ... and [1254 more](https://codecov.io/gh/apache/incubator-superset/pull/11218/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11218?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11218?src=pr&el=footer). Last update [56d5e8a...610aaea](https://codecov.io/gh/apache/incubator-superset/pull/11218?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org