You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/09/27 06:24:34 UTC

Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/
-----------------------------------------------------------

(Updated Sept. 27, 2017, 2:24 p.m.)


Review request for mesos and Gilbert Song.


Changes
-------

Fixed an issue that the container launched in this test has no blkio statistics.


Summary (updated)
-----------------

Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.


Bugs: MESOS-8013
    https://issues.apache.org/jira/browse/MESOS-8013


Repository: mesos


Description
-------

Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.


Diffs (updated)
-----

  src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
  src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
  src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/62579/diff/2/

Changes: https://reviews.apache.org/r/62579/diff/1-2/


Testing (updated)
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review186386
-----------------------------------------------------------



PASS: Mesos patch 62579 was successfully built and tested.

Reviews applied: `['62579']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62579

- Mesos Reviewbot Windows


On Sept. 27, 2017, 9:24 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 9:24 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review188673
-----------------------------------------------------------



Bad patch!

Reviews applied: [62579]

Failed command: ['bash', '-c', "set -o pipefail; export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh 2>&1 | tee build_62579"]

Error:
+ : ubuntu:14.04
+ : autotools
+ : gcc
+ : --verbose --disable-libtool-wrappers
+ : GLOG_v=1 MESOS_VERBOSE=1
+++ dirname ./support/docker-build.sh
++ cd ./support/..
++ pwd
+ MESOS_DIRECTORY=/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot
+ cd /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot
+ DOCKERFILE=Dockerfile
+ rm -f Dockerfile
+ case $OS in
+ append_dockerfile 'FROM ubuntu:14.04'
+ echo FROM ubuntu:14.04
+ append_dockerfile 'RUN rm -rf /var/lib/apt/lists/*'
+ echo RUN rm -rf /var/lib/apt/lists/apt.datadoghq.com_dists_stable_main_binary-amd64_Packages /var/lib/apt/lists/apt.datadoghq.com_dists_stable_main_binary-i386_Packages /var/lib/apt/lists/apt.datadoghq.com_dists_stable_Release /var/lib/apt/lists/apt.datadoghq.com_dists_stable_Release.gpg /var/lib/apt/lists/apt.dockerproject.org_repo_dists_ubuntu-xenial_InRelease /var/lib/apt/lists/apt.dockerproject.org_repo_dists_ubuntu-xenial_main_binary-amd64_Packages /var/lib/apt/lists/apt.puppetlabs.com_dists_xenial_Release /var/lib/apt/lists/apt.puppetlabs.com_dists_xenial_Release.gpg /var/lib/apt/lists/artifacts.elastic.co_packages_5.x_apt_dists_stable_main_binary-amd64_Packages /var/lib/apt/lists/artifacts.elastic.co_packages_5.x_apt_dists_stable_main_binary-i386_Packages /var/lib/apt/lists/artifacts.elastic.co_packages_5.x_apt_dists_stable_Release /var/lib/apt/lists/artifacts.elastic.co_packages_5.x_apt_dists_stable_Release.gpg /var/lib/apt/lists/deb.nodesource.com_node%5f6.x_dists_xenial_I
 nRelease /var/lib/apt/lists/deb.nodesource.com_node%5f6.x_dists_xenial_main_binary-amd64_Packages /var/lib/apt/lists/deb.nodesource.com_node%5f6.x_dists_xenial_main_binary-i386_Packages /var/lib/apt/lists/lock /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_xenial_main_binary-amd64_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_xenial_main_binary-i386_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_xenial_Release /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_xenial_Release.gpg /var/lib/apt/lists/packages.elastic.co_elasticsearch_2.x_debian_dists_stable_main_binary-amd64_Packages /var/lib/apt/lists/packages.elastic.co_elasticsearch_2.x_debian_dists_stable_Release /var/lib/apt/lists/packages.elastic.co_elasticsearch_2.x_debian_dists_stable_Release.gpg /var/lib/apt/lists/packages.vmware.com_packages_ubuntu_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/packages.vmware.com_packages_ubuntu_dists_trusty_main_
 binary-i386_Packages /var/lib/apt/lists/packages.vmware.com_packages_ubuntu_dists_trusty_Release /var/lib/apt/lists/packages.vmware.com_packages_ubuntu_dists_trusty_Release.gpg /var/lib/apt/lists/partial /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_InRelease /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_main_binary-amd64_Packages /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_main_binary-i386_Packages /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_main_i18n_Translation-en /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_Release /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_Release.gpg /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_InRelease /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_main_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_main_binary-
 i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_main_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_multiverse_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_multiverse_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_multiverse_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_restricted_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_restricted_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_restricted_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_universe_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_universe_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_universe_i18n_Translation
 -en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_main_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_universe_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_main_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_main_i18n_T
 ranslation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_multiverse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_restricted_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_restricted_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_universe_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_main
 _binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_multiverse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_restricted_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_restricted_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_universe_b
 inary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_universe_i18n_Translation-en
++ uname -m
+ '[' x86_64 = x86_64 ']'
+ CLANG_PKG=clang-3.5
+ append_dockerfile 'RUN apt-get update'
+ echo RUN apt-get update
+ append_dockerfile 'RUN apt-get -y install build-essential clang-3.5 git maven autoconf libtool'
+ echo RUN apt-get -y install build-essential clang-3.5 git maven autoconf libtool
+ append_dockerfile 'RUN apt-get -y install openjdk-7-jdk python-dev python-six libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev'
+ echo RUN apt-get -y install openjdk-7-jdk python-dev python-six libcurl4-nss-dev libsasl2-dev libapr1-dev libsvn-dev libevent-dev libev-dev
+ append_dockerfile 'RUN apt-get -y install wget curl sed'
+ echo RUN apt-get -y install wget curl sed
+ append_dockerfile 'RUN adduser --disabled-password --gecos '\'''\'' mesos'
+ echo RUN adduser --disabled-password --gecos ''\'''\''' mesos
+ append_dockerfile 'RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o /tmp/install-cmake.sh'
+ echo RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh -o /tmp/install-cmake.sh
+ append_dockerfile 'RUN chmod u+x /tmp/install-cmake.sh && sync && /tmp/install-cmake.sh --skip-license --prefix=/usr/local'
+ echo RUN chmod u+x /tmp/install-cmake.sh '&&' sync '&&' /tmp/install-cmake.sh --skip-license --prefix=/usr/local
+ case $COMPILER in
+ append_dockerfile 'ENV CC gcc'
+ echo ENV CC gcc
+ append_dockerfile 'ENV CXX g++'
+ echo ENV CXX g++
+ append_dockerfile 'WORKDIR mesos'
+ echo WORKDIR mesos
+ append_dockerfile 'COPY . /mesos/'
+ echo COPY . /mesos/
+ append_dockerfile 'RUN chown -R mesos /mesos'
+ echo RUN chown -R mesos /mesos
+ append_dockerfile 'USER mesos'
+ echo USER mesos
+ append_dockerfile 'ENV GTEST_OUTPUT xml:report.xml'
+ echo ENV GTEST_OUTPUT xml:report.xml
+ append_dockerfile 'ENV DISTCHECK_CONFIGURE_FLAGS --verbose --disable-libtool-wrappers'
+ echo ENV DISTCHECK_CONFIGURE_FLAGS --verbose --disable-libtool-wrappers
+ append_dockerfile 'ENV GLOG_v=1 MESOS_VERBOSE=1'
+ echo ENV GLOG_v=1 MESOS_VERBOSE=1
+ '[' -n '' ']'
+ case $BUILDTOOL in
+ append_dockerfile 'CMD ./bootstrap && ./configure --verbose --disable-libtool-wrappers && make -j6 distcheck 2>&1'
+ echo CMD ./bootstrap '&&' ./configure --verbose --disable-libtool-wrappers '&&' make -j6 distcheck '2>&1'
++ date +%s
+ TAG=mesos-1508418041-15293
+ docker build --no-cache=true -t mesos-1508418041-15293 .
Sending build context to Docker daemon  435.7MB

Step 1/19 : FROM ubuntu:14.04
14.04: Pulling from library/ubuntu
bae382666908: Pulling fs layer
29ede3c02ff2: Pulling fs layer
da4e69f33106: Pulling fs layer
8d43e5f5d27f: Pulling fs layer
b0de1abb17d6: Pulling fs layer
8d43e5f5d27f: Waiting
b0de1abb17d6: Waiting
da4e69f33106: Download complete
29ede3c02ff2: Download complete
b0de1abb17d6: Verifying Checksum
b0de1abb17d6: Download complete
8d43e5f5d27f: Download complete
bae382666908: Verifying Checksum
bae382666908: Download complete
bae382666908: Pull complete
29ede3c02ff2: Pull complete
da4e69f33106: Pull complete
8d43e5f5d27f: Pull complete
b0de1abb17d6: Pull complete
Digest: sha256:6e3e3f3c5c36a91ba17ea002f63e5607ed6a8c8e5fbbddb31ad3e15638b51ebc
Status: Downloaded newer image for ubuntu:14.04
 ---> dea1945146b9
Step 2/19 : RUN rm -rf /var/lib/apt/lists/apt.datadoghq.com_dists_stable_main_binary-amd64_Packages /var/lib/apt/lists/apt.datadoghq.com_dists_stable_main_binary-i386_Packages /var/lib/apt/lists/apt.datadoghq.com_dists_stable_Release /var/lib/apt/lists/apt.datadoghq.com_dists_stable_Release.gpg /var/lib/apt/lists/apt.dockerproject.org_repo_dists_ubuntu-xenial_InRelease /var/lib/apt/lists/apt.dockerproject.org_repo_dists_ubuntu-xenial_main_binary-amd64_Packages /var/lib/apt/lists/apt.puppetlabs.com_dists_xenial_Release /var/lib/apt/lists/apt.puppetlabs.com_dists_xenial_Release.gpg /var/lib/apt/lists/artifacts.elastic.co_packages_5.x_apt_dists_stable_main_binary-amd64_Packages /var/lib/apt/lists/artifacts.elastic.co_packages_5.x_apt_dists_stable_main_binary-i386_Packages /var/lib/apt/lists/artifacts.elastic.co_packages_5.x_apt_dists_stable_Release /var/lib/apt/lists/artifacts.elastic.co_packages_5.x_apt_dists_stable_Release.gpg /var/lib/apt/lists/deb.nodesource.com_node%5f6.x_dists_xen
 ial_InRelease /var/lib/apt/lists/deb.nodesource.com_node%5f6.x_dists_xenial_main_binary-amd64_Packages /var/lib/apt/lists/deb.nodesource.com_node%5f6.x_dists_xenial_main_binary-i386_Packages /var/lib/apt/lists/lock /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_xenial_main_binary-amd64_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_xenial_main_binary-i386_Packages /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_xenial_Release /var/lib/apt/lists/packages.apache.org_asf%5finternal_dists_xenial_Release.gpg /var/lib/apt/lists/packages.elastic.co_elasticsearch_2.x_debian_dists_stable_main_binary-amd64_Packages /var/lib/apt/lists/packages.elastic.co_elasticsearch_2.x_debian_dists_stable_Release /var/lib/apt/lists/packages.elastic.co_elasticsearch_2.x_debian_dists_stable_Release.gpg /var/lib/apt/lists/packages.vmware.com_packages_ubuntu_dists_trusty_main_binary-amd64_Packages /var/lib/apt/lists/packages.vmware.com_packages_ubuntu_dists_trusty_
 main_binary-i386_Packages /var/lib/apt/lists/packages.vmware.com_packages_ubuntu_dists_trusty_Release /var/lib/apt/lists/packages.vmware.com_packages_ubuntu_dists_trusty_Release.gpg /var/lib/apt/lists/partial /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_InRelease /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_main_binary-amd64_Packages /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_main_binary-i386_Packages /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_main_i18n_Translation-en /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_Release /var/lib/apt/lists/ppa.launchpad.net_cwchien_gradle_ubuntu_dists_xenial_Release.gpg /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_InRelease /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_main_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_main_bi
 nary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_main_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_multiverse_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_multiverse_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_multiverse_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_restricted_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_restricted_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_restricted_i18n_Translation-en /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_universe_binary-amd64_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_universe_binary-i386_Packages /var/lib/apt/lists/security.ubuntu.com_ubuntu_dists_xenial-security_universe_i18n_Transl
 ation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_main_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-backports_universe_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_main_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_main_i
 18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_multiverse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_restricted_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_restricted_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_universe_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial_universe_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_InRelease /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates
 _main_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_main_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_main_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_multiverse_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_multiverse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_multiverse_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_restricted_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_restricted_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_restricted_i18n_Translation-en /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_universe_binary-amd64_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_unive
 rse_binary-i386_Packages /var/lib/apt/lists/us.archive.ubuntu.com_ubuntu_dists_xenial-updates_universe_i18n_Translation-en
 ---> Running in fd452744bac0
 ---> 43177789d36e
Removing intermediate container fd452744bac0
Step 3/19 : RUN apt-get update
 ---> Running in 6f6b33e5f572
Get:1 http://security.ubuntu.com trusty-security InRelease [65.9 kB]
Ign http://archive.ubuntu.com trusty InRelease
Get:2 http://archive.ubuntu.com trusty-updates InRelease [65.9 kB]
Get:3 http://archive.ubuntu.com trusty-backports InRelease [65.9 kB]
Get:4 http://archive.ubuntu.com trusty Release.gpg [933 B]
Get:5 http://archive.ubuntu.com trusty Release [58.5 kB]
Get:6 http://security.ubuntu.com trusty-security/universe Sources [77.2 kB]
Get:7 http://archive.ubuntu.com trusty-updates/universe Sources [242 kB]
Get:8 http://security.ubuntu.com trusty-security/main amd64 Packages [842 kB]
Get:9 http://archive.ubuntu.com trusty-updates/main amd64 Packages [1283 kB]
Get:10 http://security.ubuntu.com trusty-security/restricted amd64 Packages [17.8 kB]
Get:11 http://security.ubuntu.com trusty-security/universe amd64 Packages [243 kB]
Get:12 http://security.ubuntu.com trusty-security/multiverse amd64 Packages [3999 B]
Get:13 http://archive.ubuntu.com trusty-updates/restricted amd64 Packages [21.1 kB]
Get:14 http://archive.ubuntu.com trusty-updates/universe amd64 Packages [555 kB]
Get:15 http://archive.ubuntu.com trusty-updates/multiverse amd64 Packages [15.5 kB]
Get:16 http://archive.ubuntu.com trusty-backports/main amd64 Packages [14.8 kB]
Get:17 http://archive.ubuntu.com trusty-backports/restricted amd64 Packages [40 B]
Get:18 http://archive.ubuntu.com trusty-backports/universe amd64 Packages [52.6 kB]
Get:19 http://archive.ubuntu.com trusty-backports/multiverse amd64 Packages [1396 B]
Get:20 http://archive.ubuntu.com trusty/universe Sources [7926 kB]
Get:21 http://archive.ubuntu.com trusty/main amd64 Packages [1743 kB]
Get:22 http://archive.ubuntu.com trusty/restricted amd64 Packages [16.0 kB]
Get:23 http://archive.ubuntu.com trusty/universe amd64 Packages [7589 kB]
Get:24 http://archive.ubuntu.com trusty/multiverse amd64 Packages [169 kB]
Fetched 21.1 MB in 10s (2061 kB/s)
Reading package lists...
failed to get digest sha256:43177789d36ee9ba2b1443b9743b7283d350d70d4407dd64f6de890a0bb8b10d: open /var/lib/docker/image/aufs/imagedb/content/sha256/43177789d36ee9ba2b1443b9743b7283d350d70d4407dd64f6de890a0bb8b10d: no such file or directory

Full log: https://builds.apache.org/job/Mesos-Reviewbot/19848/console

- Mesos Reviewbot


On Oct. 19, 2017, 12:29 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 12:29 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 936bc49ddfca03b9278ab11b6d317f3ff635cb00 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review188679
-----------------------------------------------------------



PASS: Mesos patch 62579 was successfully built and tested.

Reviews applied: `['62579']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62579

- Mesos Reviewbot Windows


On Oct. 19, 2017, 12:29 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 12:29 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 936bc49ddfca03b9278ab11b6d317f3ff635cb00 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 62579: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review190563
-----------------------------------------------------------



PASS: Mesos patch 62579 was successfully built and tested.

Reviews applied: `['62579']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62579

- Mesos Reviewbot Windows


On Nov. 9, 2017, 2:03 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 2:03 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp aad3f53c87af5e87f1b85b746d16d483ca632f83 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 62579: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review190568
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62579]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 9, 2017, 2:03 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2017, 2:03 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp aad3f53c87af5e87f1b85b746d16d483ca632f83 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 62579: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review190911
-----------------------------------------------------------


Ship it!




Ship It!

- Gilbert Song


On Nov. 8, 2017, 6:03 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2017, 6:03 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cgroups_isolator_tests.cpp aad3f53c87af5e87f1b85b746d16d483ca632f83 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/4/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 62579: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/
-----------------------------------------------------------

(Updated Nov. 9, 2017, 10:03 a.m.)


Review request for mesos and Gilbert Song.


Changes
-------

Addressed review comments.


Summary (updated)
-----------------

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.


Bugs: MESOS-8013
    https://issues.apache.org/jira/browse/MESOS-8013


Repository: mesos


Description (updated)
-------

Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_BlkioUsage`.


Diffs (updated)
-----

  src/tests/containerizer/cgroups_isolator_tests.cpp aad3f53c87af5e87f1b85b746d16d483ca632f83 


Diff: https://reviews.apache.org/r/62579/diff/4/

Changes: https://reviews.apache.org/r/62579/diff/3-4/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review190523
-----------------------------------------------------------




src/Makefile.am
Lines 2469 (patched)
<https://reviews.apache.org/r/62579/#comment267973>

    This is linux specific. Should be under OS_LINUX, right?



src/tests/CMakeLists.txt
Lines 186 (patched)
<https://reviews.apache.org/r/62579/#comment267974>

    ditto.
    
    after second thought, let's move the test to cgroups_isolator_tests.cpp for now.



src/tests/containerizer/blkio_isolator_tests.cpp
Lines 51 (patched)
<https://reviews.apache.org/r/62579/#comment267976>

    if we move to `cgroups_isolator_tests.cpp`, let's use `ROOT_CGROUPS_` prefix.


- Gilbert Song


On Oct. 19, 2017, 5:29 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2017, 5:29 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 936bc49ddfca03b9278ab11b6d317f3ff635cb00 
>   src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
>   src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/
-----------------------------------------------------------

(Updated Oct. 19, 2017, 8:29 p.m.)


Review request for mesos and Gilbert Song.


Changes
-------

Addressed review comment.


Bugs: MESOS-8013
    https://issues.apache.org/jira/browse/MESOS-8013


Repository: mesos


Description
-------

Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.


Diffs (updated)
-----

  src/Makefile.am 936bc49ddfca03b9278ab11b6d317f3ff635cb00 
  src/tests/CMakeLists.txt 386e0473c93d0a993248c7818067071d0c761c76 
  src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/62579/diff/3/

Changes: https://reviews.apache.org/r/62579/diff/2-3/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review188206
-----------------------------------------------------------




src/tests/containerizer/blkio_isolator_tests.cpp
Lines 181 (patched)
<https://reviews.apache.org/r/62579/#comment265229>

    Could you fix this:
    ```
    ../../src/tests/containerizer/blkio_isolator_tests.cpp:181
    Expected: (10u) <= (totalIOServiced.value()), actual: 10 vs 9
    ```


- Gilbert Song


On Sept. 26, 2017, 11:24 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2017, 11:24 p.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 62579: Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62579/#review188229
-----------------------------------------------------------



Patch looks great!

Reviews applied: [62579]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Sept. 27, 2017, 6:24 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62579/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2017, 6:24 a.m.)
> 
> 
> Review request for mesos and Gilbert Song.
> 
> 
> Bugs: MESOS-8013
>     https://issues.apache.org/jira/browse/MESOS-8013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `BlkioIsolatorTest.ROOT_BlkioUsage`.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 
>   src/tests/CMakeLists.txt def233d13f627f58362fdc61ac3e9c104d65fe7e 
>   src/tests/containerizer/blkio_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62579/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>