[GitHub] [superset] arkid15r commented on pull request #23685: fix(utils): evaluate date parser multiple holiday results correctly

["arkid15r (via GitHub)" <gi...@apache.org>]

arkid15r commented on PR #23685:
URL: https://github.com/apache/superset/pull/23685#issuecomment-1517985664

   > Can you use latest 0.23 version
   
   Hi Eugene, 
   that's absolutely doable. I used the current version range based on my understanding of consistency with other `install_requires` entries.
   
   >and also update the lib in `requirements/base.txt`? 
   
   I've done a couple of half-hearted attempts to update the requirements. It seems it hasn't been done for a while. Or maybe for some other reason a lot of dependencies are getting their version bumped when I run `pip-compile-multi -P holidays`. 
   
   ```
   git diff --stat
    requirements/base.txt        |  29 +++++++++++++++++-
    requirements/development.txt |   4 ---
    requirements/docker.txt      | 326 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------
    requirements/integration.txt |   8 ++---
   
   ```
   I'd appreciate some guidance on how to properly resolve this sort of issues, e.g.:
   
   ```
   Package greenlet was resolved to different versions in different environments: 1.1.3.post0 and 2.0.2
   Traceback (most recent call last):
     File "/superset/venv/lib/python3.10/site-packages/pipcompilemulti/cli_v1.py", line 26, in cli
       recompile()
     File "/superset/venv/lib/python3.10/site-packages/pipcompilemulti/actions.py", line 31, in recompile
       compile_topologically(env_confs, deduplicator)
     File "/superset/venv/lib/python3.10/site-packages/pipcompilemulti/actions.py", line 38, in compile_topologically
       if env.maybe_create_lockfile():
     File "/superset/venv/lib/python3.10/site-packages/pipcompilemulti/environment.py", line 51, in maybe_create_lockfile
       self.create_lockfile()
     File "/superset/venv/lib/python3.10/site-packages/pipcompilemulti/environment.py", line 72, in create_lockfile
       self.fix_lockfile()
     File "/superset/venv/lib/python3.10/site-packages/pipcompilemulti/environment.py", line 134, in fix_lockfile
       sections = [
     File "/superset/venv/lib/python3.10/site-packages/pipcompilemulti/environment.py", line 135, in <listcomp>
       self.fix_pin(section)
     File "/superset/venv/lib/python3.10/site-packages/pipcompilemulti/environment.py", line 211, in fix_pin
       raise RuntimeError(
   RuntimeError: Please add constraints for the package version listed above
   ```
   @EugeneTorap, I appreciate you jumping in and tagging the right people as I was within a whisker of creating a post on Slack's \#contributing channel asking for help.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org