You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@apache.org> on 2017/01/25 18:16:34 UTC
Re: Review Request 53741: Display maintainance info in the webui.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53741/#review162986
-----------------------------------------------------------
Hi, may you mind rebase this.
- haosdent huang
On Nov. 16, 2016, 7:54 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53741/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2016, 7:54 p.m.)
>
>
> Review request for mesos, haosdent huang and Joseph Wu.
>
>
> Bugs: MESOS-6443
> https://issues.apache.org/jira/browse/MESOS-6443
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Create new page with Maintenance schedule. Schedule is downloaded on
> page refresh. Schedule is not live like stats and tasks so there is
> no need to poll it periodically.
> Diable sorting when data-key is not defined in table header.
>
>
> Diffs
> -----
>
> src/webui/master/static/index.html 6211892e7d689df9bf3b2a9071a76ad4c60d0485
> src/webui/master/static/js/app.js c32177aa23c962f2bdf03d98272fb6d21a565382
> src/webui/master/static/js/controllers.js dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9
> src/webui/master/static/maintenance.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53741/diff/
>
>
> Testing
> -------
>
> [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png)
>
> Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853)
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
Re: Review Request 53741: Display maintainance info in the webui.
Posted by Tomasz Janiszewski <ja...@gmail.com>.
> On Jan. 25, 2017, 6:16 p.m., haosdent huang wrote:
> > Hi, may you mind rebase this.
Done.
- Tomasz
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53741/#review162986
-----------------------------------------------------------
On Jan. 29, 2017, 2:48 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53741/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2017, 2:48 p.m.)
>
>
> Review request for mesos, haosdent huang and Joseph Wu.
>
>
> Bugs: MESOS-6443
> https://issues.apache.org/jira/browse/MESOS-6443
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Create new page with Maintenance schedule. Schedule is downloaded on
> page refresh. Schedule is not live like stats and tasks so there is
> no need to poll it periodically.
> Diable sorting when data-key is not defined in table header.
>
>
> Diffs
> -----
>
> src/webui/master/static/index.html 7c6a8ad56437c2315fc563d469ed0426286b48ce
> src/webui/master/static/js/app.js 558a67ddf59a39db43023b4f7aa26b7e319924b0
> src/webui/master/static/js/controllers.js 07bc612a4d7a6b4b418de964303e8fb7083b5d31
> src/webui/master/static/maintenance.html PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53741/diff/
>
>
> Testing
> -------
>
> [Screenshot](https://issues.apache.org/jira/secure/attachment/12838845/mesos_webui_maintenance_schedule.png)
>
> Testing done maually on Ubuntu/Chrome. Perfomrance testing done with 500 entires schedule generated with [generate_schedule.py](https://gist.github.com/janisz/e4dcb001f19aa4b466f9112a6dd16853)
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>