You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Pinal Shah <pi...@freestoneinfotech.com> on 2020/03/04 05:05:25 UTC
Review Request 72188: ATLAS-3650 : Basic Search: query of typeName
doesn't
apply when it has many subTypes(like Asset) in combination with attribute
filter
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72188/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3650
https://issues.apache.org/jira/browse/ATLAS-3650
Repository: atlas
Description
-------
When Asset typeName, which has many subtypes, with some attribute filter is searched ,
query formed for typeName is not included in final query
Diffs
-----
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 8f531876b
Diff: https://reviews.apache.org/r/72188/diff/1/
Testing
-------
1) Select Asset
2) Select Guid notNull
--> Before, all entities with guid notnull including internal Type(AtlasGlossary) where coming in result
--> Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result
Thanks,
Pinal Shah
Re: Review Request 72188: ATLAS-3650 : Basic Search: query of typeName
doesn't apply when it has many subTypes(like Asset) in combination with
attribute filter
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
> On March 4, 2020, 5:10 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
> > Lines 126 (patched)
> > <https://reviews.apache.org/r/72188/diff/1/?file=2212720#file2212720line126>
> >
> > typeNamePredicate could be null - see #100.
> >
> > Consider alternate fix of moving #114 - #116 outside the 'if' block at #110.
Thanks Madhan,
I think once ATLAS-3618(https://reviews.apache.org/r/72156) is committed,
I can incooperate changes in it, because this patch is dependent on ATLAS-3618.
- Pinal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72188/#review219747
-----------------------------------------------------------
On March 4, 2020, 5:05 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72188/
> -----------------------------------------------------------
>
> (Updated March 4, 2020, 5:05 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3650
> https://issues.apache.org/jira/browse/ATLAS-3650
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When Asset typeName, which has many subtypes, with some attribute filter is searched ,
> query formed for typeName is not included in final query
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 8f531876b
>
>
> Diff: https://reviews.apache.org/r/72188/diff/1/
>
>
> Testing
> -------
>
> 1) Select Asset
> 2) Select Guid notNull
> --> Before, all entities with guid notnull including internal Type(AtlasGlossary) where coming in result
> --> Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72188: ATLAS-3650 : Basic Search: query of typeName
doesn't apply when it has many subTypes(like Asset) in combination with
attribute filter
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72188/#review219747
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Lines 126 (patched)
<https://reviews.apache.org/r/72188/#comment307947>
typeNamePredicate could be null - see #100.
Consider alternate fix of moving #114 - #116 outside the 'if' block at #110.
- Madhan Neethiraj
On March 4, 2020, 5:05 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72188/
> -----------------------------------------------------------
>
> (Updated March 4, 2020, 5:05 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3650
> https://issues.apache.org/jira/browse/ATLAS-3650
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When Asset typeName, which has many subtypes, with some attribute filter is searched ,
> query formed for typeName is not included in final query
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java 8f531876b
>
>
> Diff: https://reviews.apache.org/r/72188/diff/1/
>
>
> Testing
> -------
>
> 1) Select Asset
> 2) Select Guid notNull
> --> Before, all entities with guid notnull including internal Type(AtlasGlossary) where coming in result
> --> Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72188: ATLAS-3650 : Basic Search: query of typeName
doesn't apply when it has many subTypes(like Asset) in combination with
attribute filter
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72188/#review219945
-----------------------------------------------------------
Fix it, then Ship it!
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Line 121 (original)
<https://reviews.apache.org/r/72188/#comment308187>
I suggest to retain attributePredicates in inMemoryPredicate. IIRC, they were added to account for excessive results from index/graph queries.
- Madhan Neethiraj
On March 13, 2020, 11:10 a.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72188/
> -----------------------------------------------------------
>
> (Updated March 13, 2020, 11:10 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3650
> https://issues.apache.org/jira/browse/ATLAS-3650
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When Asset typeName, which has many subtypes, with some attribute filter is searched ,
> query formed for typeName is not included in final query
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java c9f3166f1
>
>
> Diff: https://reviews.apache.org/r/72188/diff/2/
>
>
> Testing
> -------
>
> 1) Select Asset
> 2) Select Guid notNull
> --> Before, all entities with guid notnull including internal Type(AtlasGlossary) where coming in result
> --> Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72188: ATLAS-3650 : Basic Search: query of typeName
doesn't apply when it has many subTypes(like Asset) in combination with
attribute filter
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72188/#review219960
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 16, 2020, 12:45 p.m., Pinal Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72188/
> -----------------------------------------------------------
>
> (Updated March 16, 2020, 12:45 p.m.)
>
>
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3650
> https://issues.apache.org/jira/browse/ATLAS-3650
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When Asset typeName, which has many subtypes, with some attribute filter is searched ,
> query formed for typeName is not included in final query
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java c9f3166f1
>
>
> Diff: https://reviews.apache.org/r/72188/diff/3/
>
>
> Testing
> -------
>
> 1) Select Asset
> 2) Select Guid notNull
> --> Before, all entities with guid notnull including internal Type(AtlasGlossary) where coming in result
> --> Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result
>
>
> Thanks,
>
> Pinal Shah
>
>
Re: Review Request 72188: ATLAS-3650 : Basic Search: query of typeName
doesn't apply when it has many subTypes(like Asset) in combination with
attribute filter
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72188/
-----------------------------------------------------------
(Updated March 16, 2020, 12:45 p.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Changes
-------
retained attributePredicate
Bugs: ATLAS-3650
https://issues.apache.org/jira/browse/ATLAS-3650
Repository: atlas
Description
-------
When Asset typeName, which has many subtypes, with some attribute filter is searched ,
query formed for typeName is not included in final query
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java c9f3166f1
Diff: https://reviews.apache.org/r/72188/diff/3/
Changes: https://reviews.apache.org/r/72188/diff/2-3/
Testing
-------
1) Select Asset
2) Select Guid notNull
--> Before, all entities with guid notnull including internal Type(AtlasGlossary) where coming in result
--> Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result
Thanks,
Pinal Shah
Re: Review Request 72188: ATLAS-3650 : Basic Search: query of typeName
doesn't apply when it has many subTypes(like Asset) in combination with
attribute filter
Posted by Pinal Shah <pi...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72188/
-----------------------------------------------------------
(Updated March 13, 2020, 11:10 a.m.)
Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian.
Bugs: ATLAS-3650
https://issues.apache.org/jira/browse/ATLAS-3650
Repository: atlas
Description
-------
When Asset typeName, which has many subtypes, with some attribute filter is searched ,
query formed for typeName is not included in final query
Diffs (updated)
-----
repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java c9f3166f1
Diff: https://reviews.apache.org/r/72188/diff/2/
Changes: https://reviews.apache.org/r/72188/diff/1-2/
Testing
-------
1) Select Asset
2) Select Guid notNull
--> Before, all entities with guid notnull including internal Type(AtlasGlossary) where coming in result
--> Now, Entities with typeName Asset and allSubtypes with guid notnull is coming in result
Thanks,
Pinal Shah