You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jason Huynh <jh...@pivotal.io> on 2017/03/01 23:45:44 UTC
Review Request 57225: GEODE-2571 CacheClosedException during
LuceneQueryFunction should be handled with a retry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57225/
-----------------------------------------------------------
Review request for geode, Lynn Hughes-Godfrey, nabarun nag, Dan Smith, and xiaojian zhou.
Repository: geode
Description
-------
Added try catch around retrieving lucene index to handle cache clossed exception
Added catch during bucket querying to handle cache closed exception
minor refactoring to break down the execute method
Modified expected exception in tests to be more specific for certain tests
Added tests
Diffs
-----
geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java dd70480
geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java 6a9af9b
Diff: https://reviews.apache.org/r/57225/diff/1/
Testing
-------
geode-lucene:precheckin
Thanks,
Jason Huynh
Re: Review Request 57225: GEODE-2571 CacheClosedException during
LuceneQueryFunction should be handled with a retry
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57225/#review167609
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Smith
On March 1, 2017, 11:45 p.m., Jason Huynh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57225/
> -----------------------------------------------------------
>
> (Updated March 1, 2017, 11:45 p.m.)
>
>
> Review request for geode, Lynn Hughes-Godfrey, nabarun nag, Dan Smith, and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> Added try catch around retrieving lucene index to handle cache clossed exception
> Added catch during bucket querying to handle cache closed exception
> minor refactoring to break down the execute method
> Modified expected exception in tests to be more specific for certain tests
> Added tests
>
>
> Diffs
> -----
>
> geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java dd70480
> geode-lucene/src/test/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunctionJUnitTest.java 6a9af9b
>
>
> Diff: https://reviews.apache.org/r/57225/diff/1/
>
>
> Testing
> -------
>
> geode-lucene:precheckin
>
>
> Thanks,
>
> Jason Huynh
>
>