You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Welch, Matt" <ma...@intel.com> on 2024/08/14 18:05:22 UTC

[VOTE] KIP-1052: Enable warmup in producer performance test

Hi all, 
 
It seems discussion has been quiet for a couple of weeks so I'd like to call a vote on KIP-1052 https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable+warmup+in+producer+performance+test
 
Thanks,
Matt Welch


RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by Chia-Ping Tsai <ch...@apache.org>.
hi Matt

Apologies for the delayed response. I completely agree that ProducerPerformance should separate warmup statistics from steady-state metrics. Overall +1, but I have a small question:

Have you considered implementing an explicit check for warmup instead of relying on sending a set number of records? My concern is that users may not know how many records are necessary to complete the warmup. Rather than relying on a rule of thumb, ProducerPerformance could check the metadata and node latency (via metrics) to ensure that the node information (such as connection, DNS, and metadata) is ready. 

In summary, this approach introduces a flag called enable-warmup instead of using warmup-records. The advantage is that users no longer need to specify the number of warmup records. When the flag is enabled, ProducerPerformance will continue sending warmup records until the node information is fully ready.

Best,
Chia-Ping

On 2024/09/04 22:20:15 "Welch, Matt" wrote:
> Hi Kafka devs, 
> 
> Bumping this VOTE thread again for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Welch, Matt <ma...@intel.com> 
> Sent: Friday, August 23, 2024 4:26 PM
> To: dev@kafka.apache.org
> Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance test
> 
> Hi Kafka devs, 
> 
> Bumping this VOTE thread for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Federico Valeri <fe...@gmail.com>
> Sent: Monday, August 19, 2024 12:38 AM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test
> 
> Hi Matt, +1 (non binding) from me. Thanks!
> 
> Just a suggestion: I think that the following output line does not add much value and could be removed.
> 
> "Warmup first 100000 records. Steady-state results will print after the complete-test summary."
> 
> On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
> >
> >
> > Hi all,
> >
> > It seems discussion has been quiet for a couple of weeks so I'd like 
> > to call a vote on KIP-1052 
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable+w
> > armup+in+producer+performance+test
> >
> > Thanks,
> > Matt Welch
> >
> 

Re: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by Chia-Ping Tsai <ch...@gmail.com>.
hi Matt

thanks for your response. +1 (binding)

Best,
Chia-Ping

Welch, Matt <ma...@intel.com> 於 2024年9月27日 週五 上午2:31寫道:

> Hi Chia-Ping
>
> Earlier in the discussion phase, Federico Valeri has also proposed the
> idea of a "producer autopilot" which could switch to a steady state mode
> once the p99 was acceptably stable.
> I agree with both of you that an automatic warmup would be a very useful
> addition to the producer performance tooling, but creating a universal
> definition of "stable" and the automatic detection of stability are both
> somewhat complex. For these reasons, I think it's best that automatic
> warmup is contained in a follow-on KIP. I've attempted to include your
> ideas in the Rejected Alternatives section of the KIP.
>
> Thanks,
> Matt
>
> -----Original Message-----
> From: Chia-Ping Tsai <ch...@apache.org>
> Sent: Tuesday, September 24, 2024 4:22 AM
> To: dev@kafka.apache.org
> Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance test
>
> hi Matt
>
> Apologies for the delayed response. I completely agree that
> ProducerPerformance should separate warmup statistics from steady-state
> metrics. Overall +1, but I have a small question:
>
> Have you considered implementing an explicit check for warmup instead of
> relying on sending a set number of records? My concern is that users may
> not know how many records are necessary to complete the warmup. Rather than
> relying on a rule of thumb, ProducerPerformance could check the metadata
> and node latency (via metrics) to ensure that the node information (such as
> connection, DNS, and metadata) is ready.
>
> In summary, this approach introduces a flag called enable-warmup instead
> of using warmup-records. The advantage is that users no longer need to
> specify the number of warmup records. When the flag is enabled,
> ProducerPerformance will continue sending warmup records until the node
> information is fully ready.
>
> Best,
> Chia-Ping
>
> On 2024/09/04 22:20:15 "Welch, Matt" wrote:
> > Hi Kafka devs,
> >
> > Bumping this VOTE thread again for visibility.
> >
> > Thanks,
> > Matt
> >
> > -----Original Message-----
> > From: Welch, Matt <ma...@intel.com>
> > Sent: Friday, August 23, 2024 4:26 PM
> > To: dev@kafka.apache.org
> > Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance
> > test
> >
> > Hi Kafka devs,
> >
> > Bumping this VOTE thread for visibility.
> >
> > Thanks,
> > Matt
> >
> > -----Original Message-----
> > From: Federico Valeri <fe...@gmail.com>
> > Sent: Monday, August 19, 2024 12:38 AM
> > To: dev@kafka.apache.org
> > Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance
> > test
> >
> > Hi Matt, +1 (non binding) from me. Thanks!
> >
> > Just a suggestion: I think that the following output line does not add
> much value and could be removed.
> >
> > "Warmup first 100000 records. Steady-state results will print after the
> complete-test summary."
> >
> > On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com>
> wrote:
> > >
> > >
> > > Hi all,
> > >
> > > It seems discussion has been quiet for a couple of weeks so I'd like
> > > to call a vote on KIP-1052
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable
> > > +w
> > > armup+in+producer+performance+test
> > >
> > > Thanks,
> > > Matt Welch
> > >
> >
>

RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by "Welch, Matt" <ma...@intel.com>.
Hi Chia-Ping

Earlier in the discussion phase, Federico Valeri has also proposed the idea of a "producer autopilot" which could switch to a steady state mode once the p99 was acceptably stable.  
I agree with both of you that an automatic warmup would be a very useful addition to the producer performance tooling, but creating a universal definition of "stable" and the automatic detection of stability are both somewhat complex. For these reasons, I think it's best that automatic warmup is contained in a follow-on KIP. I've attempted to include your ideas in the Rejected Alternatives section of the KIP.

Thanks,
Matt

-----Original Message-----
From: Chia-Ping Tsai <ch...@apache.org> 
Sent: Tuesday, September 24, 2024 4:22 AM
To: dev@kafka.apache.org
Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance test

hi Matt

Apologies for the delayed response. I completely agree that ProducerPerformance should separate warmup statistics from steady-state metrics. Overall +1, but I have a small question:

Have you considered implementing an explicit check for warmup instead of relying on sending a set number of records? My concern is that users may not know how many records are necessary to complete the warmup. Rather than relying on a rule of thumb, ProducerPerformance could check the metadata and node latency (via metrics) to ensure that the node information (such as connection, DNS, and metadata) is ready. 

In summary, this approach introduces a flag called enable-warmup instead of using warmup-records. The advantage is that users no longer need to specify the number of warmup records. When the flag is enabled, ProducerPerformance will continue sending warmup records until the node information is fully ready.

Best,
Chia-Ping

On 2024/09/04 22:20:15 "Welch, Matt" wrote:
> Hi Kafka devs,
> 
> Bumping this VOTE thread again for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Welch, Matt <ma...@intel.com>
> Sent: Friday, August 23, 2024 4:26 PM
> To: dev@kafka.apache.org
> Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance 
> test
> 
> Hi Kafka devs,
> 
> Bumping this VOTE thread for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Federico Valeri <fe...@gmail.com>
> Sent: Monday, August 19, 2024 12:38 AM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance 
> test
> 
> Hi Matt, +1 (non binding) from me. Thanks!
> 
> Just a suggestion: I think that the following output line does not add much value and could be removed.
> 
> "Warmup first 100000 records. Steady-state results will print after the complete-test summary."
> 
> On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
> >
> >
> > Hi all,
> >
> > It seems discussion has been quiet for a couple of weeks so I'd like 
> > to call a vote on KIP-1052 
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable
> > +w
> > armup+in+producer+performance+test
> >
> > Thanks,
> > Matt Welch
> >
> 

RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by Chia-Ping Tsai <ch...@apache.org>.
hi Matt

Apologies for the delayed response. I completely agree that ProducerPerformance should separate warmup statistics from steady-state metrics. Overall +1, but I have a small question:

Have you considered implementing an explicit check for warmup instead of relying on sending a set number of records? My concern is that users may not know how many records are necessary to complete the warmup. Rather than relying on a rule of thumb, ProducerPerformance could check the metadata and node latency (via metrics) to ensure that the node information (such as connection, DNS, and metadata) is ready. 

In summary, this approach introduces a flag called enable-warmup instead of using warmup-records. The advantage is that users no longer need to specify the number of warmup records. When the flag is enabled, ProducerPerformance will continue sending warmup records until the node information is fully ready.

Best,
Chia-Ping

On 2024/09/04 22:20:15 "Welch, Matt" wrote:
> Hi Kafka devs, 
> 
> Bumping this VOTE thread again for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Welch, Matt <ma...@intel.com> 
> Sent: Friday, August 23, 2024 4:26 PM
> To: dev@kafka.apache.org
> Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance test
> 
> Hi Kafka devs, 
> 
> Bumping this VOTE thread for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Federico Valeri <fe...@gmail.com>
> Sent: Monday, August 19, 2024 12:38 AM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test
> 
> Hi Matt, +1 (non binding) from me. Thanks!
> 
> Just a suggestion: I think that the following output line does not add much value and could be removed.
> 
> "Warmup first 100000 records. Steady-state results will print after the complete-test summary."
> 
> On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
> >
> >
> > Hi all,
> >
> > It seems discussion has been quiet for a couple of weeks so I'd like 
> > to call a vote on KIP-1052 
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable+w
> > armup+in+producer+performance+test
> >
> > Thanks,
> > Matt Welch
> >
> 

RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by Chia-Ping Tsai <ch...@apache.org>.
hi Matt

Apologies for the delayed response. I completely agree that ProducerPerformance should separate warmup statistics from steady-state metrics. Overall +1, but I have a small question:

Have you considered implementing an explicit check for warmup instead of relying on sending a set number of records? My concern is that users may not know how many records are necessary to complete the warmup. Rather than relying on a rule of thumb, ProducerPerformance could check the metadata and node latency (via metrics) to ensure that the node information (such as connection, DNS, and metadata) is ready. 

In summary, this approach introduces a flag called enable-warmup instead of using warmup-records. The advantage is that users no longer need to specify the number of warmup records. When the flag is enabled, ProducerPerformance will continue sending warmup records until the node information is fully ready.

Best,
Chia-Ping

On 2024/09/04 22:20:15 "Welch, Matt" wrote:
> Hi Kafka devs, 
> 
> Bumping this VOTE thread again for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Welch, Matt <ma...@intel.com> 
> Sent: Friday, August 23, 2024 4:26 PM
> To: dev@kafka.apache.org
> Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance test
> 
> Hi Kafka devs, 
> 
> Bumping this VOTE thread for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Federico Valeri <fe...@gmail.com>
> Sent: Monday, August 19, 2024 12:38 AM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test
> 
> Hi Matt, +1 (non binding) from me. Thanks!
> 
> Just a suggestion: I think that the following output line does not add much value and could be removed.
> 
> "Warmup first 100000 records. Steady-state results will print after the complete-test summary."
> 
> On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
> >
> >
> > Hi all,
> >
> > It seems discussion has been quiet for a couple of weeks so I'd like 
> > to call a vote on KIP-1052 
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable+w
> > armup+in+producer+performance+test
> >
> > Thanks,
> > Matt Welch
> >
> 

RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by Chia-Ping Tsai <ch...@apache.org>.
Oh, I apologize for not enabling idempotence on my email producer... :(

On 2024/09/04 22:20:15 "Welch, Matt" wrote:
> Hi Kafka devs, 
> 
> Bumping this VOTE thread again for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Welch, Matt <ma...@intel.com> 
> Sent: Friday, August 23, 2024 4:26 PM
> To: dev@kafka.apache.org
> Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance test
> 
> Hi Kafka devs, 
> 
> Bumping this VOTE thread for visibility.
> 
> Thanks,
> Matt
> 
> -----Original Message-----
> From: Federico Valeri <fe...@gmail.com>
> Sent: Monday, August 19, 2024 12:38 AM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test
> 
> Hi Matt, +1 (non binding) from me. Thanks!
> 
> Just a suggestion: I think that the following output line does not add much value and could be removed.
> 
> "Warmup first 100000 records. Steady-state results will print after the complete-test summary."
> 
> On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
> >
> >
> > Hi all,
> >
> > It seems discussion has been quiet for a couple of weeks so I'd like 
> > to call a vote on KIP-1052 
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable+w
> > armup+in+producer+performance+test
> >
> > Thanks,
> > Matt Welch
> >
> 

RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by "Welch, Matt" <ma...@intel.com>.
Thank you David and Chia-Ping for voting.
@David I added the mention of the new command line argument in the public interfaces section.

This brings our total to +3 binding, +1 non-binding so I will conclude the vote as *approved*:
Federico Valeri: +1 (non-binding)
Justine Olshan: +1 (binding)
David Jacot: +1 (binding)
Chia-Ping Tsai: +1 (binding)

Many thanks to Divij, Luke, Federico, Justine, David, and Chia-Ping for the great discussion and support!

Best Regards,
Matt

-----Original Message-----
From: David Jacot <dj...@confluent.io.INVALID> 
Sent: Tuesday, September 24, 2024 12:44 AM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test

Hi Matt,

Thanks for the KIP. I have a minor nit. Could you please explicitly mention the new command line argument in the public interfaces section?

Otherwise, I am +1 (binding).

Best,
David


On Tue, Sep 24, 2024 at 1:48 AM Welch, Matt <ma...@intel.com> wrote:

> Hi Kafka Devs,
>
> Bumping VOTE thread again for visibility.
>
> Thanks to Justine and Federico who've cast their votes on KIP-1052!
> Current vote tally:
>         Justine Olshan: +1 (binding)
>         Federico Valeri: +1 (non-binding)
>
> Let's keep it going and complete this vote!
>
> Thanks,
> Matt
>
> -----Original Message-----
> From: Justine Olshan <jo...@confluent.io.INVALID>
> Sent: Wednesday, September 11, 2024 4:36 PM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance 
> test
>
> +1 (binding) from me.
>
> Thanks,
> Justine
>
> On Wed, Sep 4, 2024 at 3:22 PM Welch, Matt <ma...@intel.com> wrote:
>
> > Hi Kafka devs,
> >
> > Bumping this VOTE thread again for visibility.
> >
> > Thanks,
> > Matt
> >
> > -----Original Message-----
> > From: Welch, Matt <ma...@intel.com>
> > Sent: Friday, August 23, 2024 4:26 PM
> > To: dev@kafka.apache.org
> > Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance 
> > test
> >
> > Hi Kafka devs,
> >
> > Bumping this VOTE thread for visibility.
> >
> > Thanks,
> > Matt
> >
> > -----Original Message-----
> > From: Federico Valeri <fe...@gmail.com>
> > Sent: Monday, August 19, 2024 12:38 AM
> > To: dev@kafka.apache.org
> > Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance 
> > test
> >
> > Hi Matt, +1 (non binding) from me. Thanks!
> >
> > Just a suggestion: I think that the following output line does not 
> > add much value and could be removed.
> >
> > "Warmup first 100000 records. Steady-state results will print after 
> > the complete-test summary."
> >
> > On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com>
> wrote:
> > >
> > >
> > > Hi all,
> > >
> > > It seems discussion has been quiet for a couple of weeks so I'd 
> > > like to call a vote on KIP-1052 
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enab
> > > le
> > > +w
> > > armup+in+producer+performance+test
> > >
> > > Thanks,
> > > Matt Welch
> > >
> >
>

Re: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by David Jacot <dj...@confluent.io.INVALID>.
Hi Matt,

Thanks for the KIP. I have a minor nit. Could you please explicitly mention
the new command line argument in the public interfaces section?

Otherwise, I am +1 (binding).

Best,
David


On Tue, Sep 24, 2024 at 1:48 AM Welch, Matt <ma...@intel.com> wrote:

> Hi Kafka Devs,
>
> Bumping VOTE thread again for visibility.
>
> Thanks to Justine and Federico who've cast their votes on KIP-1052!
> Current vote tally:
>         Justine Olshan: +1 (binding)
>         Federico Valeri: +1 (non-binding)
>
> Let's keep it going and complete this vote!
>
> Thanks,
> Matt
>
> -----Original Message-----
> From: Justine Olshan <jo...@confluent.io.INVALID>
> Sent: Wednesday, September 11, 2024 4:36 PM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test
>
> +1 (binding) from me.
>
> Thanks,
> Justine
>
> On Wed, Sep 4, 2024 at 3:22 PM Welch, Matt <ma...@intel.com> wrote:
>
> > Hi Kafka devs,
> >
> > Bumping this VOTE thread again for visibility.
> >
> > Thanks,
> > Matt
> >
> > -----Original Message-----
> > From: Welch, Matt <ma...@intel.com>
> > Sent: Friday, August 23, 2024 4:26 PM
> > To: dev@kafka.apache.org
> > Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance
> > test
> >
> > Hi Kafka devs,
> >
> > Bumping this VOTE thread for visibility.
> >
> > Thanks,
> > Matt
> >
> > -----Original Message-----
> > From: Federico Valeri <fe...@gmail.com>
> > Sent: Monday, August 19, 2024 12:38 AM
> > To: dev@kafka.apache.org
> > Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance
> > test
> >
> > Hi Matt, +1 (non binding) from me. Thanks!
> >
> > Just a suggestion: I think that the following output line does not add
> > much value and could be removed.
> >
> > "Warmup first 100000 records. Steady-state results will print after
> > the complete-test summary."
> >
> > On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com>
> wrote:
> > >
> > >
> > > Hi all,
> > >
> > > It seems discussion has been quiet for a couple of weeks so I'd like
> > > to call a vote on KIP-1052
> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable
> > > +w
> > > armup+in+producer+performance+test
> > >
> > > Thanks,
> > > Matt Welch
> > >
> >
>

RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by "Welch, Matt" <ma...@intel.com>.
Hi Kafka Devs, 

Bumping VOTE thread again for visibility.

Thanks to Justine and Federico who've cast their votes on KIP-1052!
Current vote tally:
	Justine Olshan: +1 (binding)
	Federico Valeri: +1 (non-binding)

Let's keep it going and complete this vote!

Thanks,
Matt

-----Original Message-----
From: Justine Olshan <jo...@confluent.io.INVALID> 
Sent: Wednesday, September 11, 2024 4:36 PM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test

+1 (binding) from me.

Thanks,
Justine

On Wed, Sep 4, 2024 at 3:22 PM Welch, Matt <ma...@intel.com> wrote:

> Hi Kafka devs,
>
> Bumping this VOTE thread again for visibility.
>
> Thanks,
> Matt
>
> -----Original Message-----
> From: Welch, Matt <ma...@intel.com>
> Sent: Friday, August 23, 2024 4:26 PM
> To: dev@kafka.apache.org
> Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance 
> test
>
> Hi Kafka devs,
>
> Bumping this VOTE thread for visibility.
>
> Thanks,
> Matt
>
> -----Original Message-----
> From: Federico Valeri <fe...@gmail.com>
> Sent: Monday, August 19, 2024 12:38 AM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance 
> test
>
> Hi Matt, +1 (non binding) from me. Thanks!
>
> Just a suggestion: I think that the following output line does not add 
> much value and could be removed.
>
> "Warmup first 100000 records. Steady-state results will print after 
> the complete-test summary."
>
> On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
> >
> >
> > Hi all,
> >
> > It seems discussion has been quiet for a couple of weeks so I'd like 
> > to call a vote on KIP-1052 
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable
> > +w
> > armup+in+producer+performance+test
> >
> > Thanks,
> > Matt Welch
> >
>

Re: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by Justine Olshan <jo...@confluent.io.INVALID>.
+1 (binding) from me.

Thanks,
Justine

On Wed, Sep 4, 2024 at 3:22 PM Welch, Matt <ma...@intel.com> wrote:

> Hi Kafka devs,
>
> Bumping this VOTE thread again for visibility.
>
> Thanks,
> Matt
>
> -----Original Message-----
> From: Welch, Matt <ma...@intel.com>
> Sent: Friday, August 23, 2024 4:26 PM
> To: dev@kafka.apache.org
> Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance test
>
> Hi Kafka devs,
>
> Bumping this VOTE thread for visibility.
>
> Thanks,
> Matt
>
> -----Original Message-----
> From: Federico Valeri <fe...@gmail.com>
> Sent: Monday, August 19, 2024 12:38 AM
> To: dev@kafka.apache.org
> Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test
>
> Hi Matt, +1 (non binding) from me. Thanks!
>
> Just a suggestion: I think that the following output line does not add
> much value and could be removed.
>
> "Warmup first 100000 records. Steady-state results will print after the
> complete-test summary."
>
> On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
> >
> >
> > Hi all,
> >
> > It seems discussion has been quiet for a couple of weeks so I'd like
> > to call a vote on KIP-1052
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable+w
> > armup+in+producer+performance+test
> >
> > Thanks,
> > Matt Welch
> >
>

RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by "Welch, Matt" <ma...@intel.com>.
Hi Kafka devs, 

Bumping this VOTE thread again for visibility.

Thanks,
Matt

-----Original Message-----
From: Welch, Matt <ma...@intel.com> 
Sent: Friday, August 23, 2024 4:26 PM
To: dev@kafka.apache.org
Subject: RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Hi Kafka devs, 

Bumping this VOTE thread for visibility.

Thanks,
Matt

-----Original Message-----
From: Federico Valeri <fe...@gmail.com>
Sent: Monday, August 19, 2024 12:38 AM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test

Hi Matt, +1 (non binding) from me. Thanks!

Just a suggestion: I think that the following output line does not add much value and could be removed.

"Warmup first 100000 records. Steady-state results will print after the complete-test summary."

On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
>
>
> Hi all,
>
> It seems discussion has been quiet for a couple of weeks so I'd like 
> to call a vote on KIP-1052 
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable+w
> armup+in+producer+performance+test
>
> Thanks,
> Matt Welch
>

RE: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by "Welch, Matt" <ma...@intel.com>.
Hi Kafka devs, 

Bumping this VOTE thread for visibility.

Thanks,
Matt

-----Original Message-----
From: Federico Valeri <fe...@gmail.com> 
Sent: Monday, August 19, 2024 12:38 AM
To: dev@kafka.apache.org
Subject: Re: [VOTE] KIP-1052: Enable warmup in producer performance test

Hi Matt, +1 (non binding) from me. Thanks!

Just a suggestion: I think that the following output line does not add much value and could be removed.

"Warmup first 100000 records. Steady-state results will print after the complete-test summary."

On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
>
>
> Hi all,
>
> It seems discussion has been quiet for a couple of weeks so I'd like 
> to call a vote on KIP-1052 
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable+w
> armup+in+producer+performance+test
>
> Thanks,
> Matt Welch
>

Re: [VOTE] KIP-1052: Enable warmup in producer performance test

Posted by Federico Valeri <fe...@gmail.com>.
Hi Matt, +1 (non binding) from me. Thanks!

Just a suggestion: I think that the following output line does not add
much value and could be removed.

"Warmup first 100000 records. Steady-state results will print after
the complete-test summary."

On Wed, Aug 14, 2024 at 8:06 PM Welch, Matt <ma...@intel.com> wrote:
>
>
> Hi all,
>
> It seems discussion has been quiet for a couple of weeks so I'd like to call a vote on KIP-1052 https://cwiki.apache.org/confluence/display/KAFKA/KIP-1052%3A+Enable+warmup+in+producer+performance+test
>
> Thanks,
> Matt Welch
>