You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Rowe (JIRA)" <ji...@apache.org> on 2012/05/18 18:55:08 UTC
[jira] [Updated] (LUCENE-3983) HTMLCharacterEntities.jflex uses
String.toUpperCase without Locale
[ https://issues.apache.org/jira/browse/LUCENE-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steven Rowe updated LUCENE-3983:
--------------------------------
Attachment: LUCENE-3983.patch
Patch removing runtime upcasing, as in my previous comment.
Committing shortly.
> HTMLCharacterEntities.jflex uses String.toUpperCase without Locale
> ------------------------------------------------------------------
>
> Key: LUCENE-3983
> URL: https://issues.apache.org/jira/browse/LUCENE-3983
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Uwe Schindler
> Assignee: Steven Rowe
> Priority: Minor
> Attachments: LUCENE-3983.patch
>
>
> Is this expected?
> {code:java}
> "xi", "\u03BE", "yacute", "\u00FD", "yen", "\u00A5", "yuml", "\u00FF",
> "zeta", "\u03B6", "zwj", "\u200D", "zwnj", "\u200C"
> };
> for (int i = 0 ; i < entities.length ; i += 2) {
> Character value = entities[i + 1].charAt(0);
> entityValues.put(entities[i], value);
> if (upperCaseVariantsAccepted.contains(entities[i])) {
> entityValues.put(entities[i].toUpperCase(), value);
> }
> }
> {code}
> In my opinion, this should look like:
> {code:java}
> "xi", "\u03BE", "yacute", "\u00FD", "yen", "\u00A5", "yuml", "\u00FF",
> "zeta", "\u03B6", "zwj", "\u200D", "zwnj", "\u200C"
> };
> for (int i = 0 ; i < entities.length ; i += 2) {
> Character value = entities[i + 1].charAt(0);
> entityValues.put(entities[i], value);
> if (upperCaseVariantsAccepted.contains(entities[i])) {
> entityValues.put(entities[i].toUpperCase(Locale.ENGLISH), value);
> }
> }
> {code}
> (otherwise in the Turkish locale, the entities containing "i" (like "xi" -> '\u03BE') will not be detected correctly).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org