You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/16 19:47:04 UTC
[GitHub] codecov-io edited a comment on issue #5376: [bugfix] make
MetricsControl work with DECK visualizations
codecov-io edited a comment on issue #5376: [bugfix] make MetricsControl work with DECK visualizations
URL: https://github.com/apache/incubator-superset/pull/5376#issuecomment-405359314
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5376?src=pr&el=h1) Report
> Merging [#5376](https://codecov.io/gh/apache/incubator-superset/pull/5376?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/bd475879a47150dc549f06778cd8fa098089b16f?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `88%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/5376?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5376 +/- ##
==========================================
+ Coverage 61.34% 61.42% +0.08%
==========================================
Files 373 373
Lines 23521 23539 +18
Branches 2725 2725
==========================================
+ Hits 14429 14459 +30
+ Misses 9079 9067 -12
Partials 13 13
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5376?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/explore/visTypes.js](https://codecov.io/gh/apache/incubator-superset/pull/5376/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3Zpc1R5cGVzLmpz) | `55.55% <ø> (ø)` | :arrow_up: |
| [superset/assets/src/logger.js](https://codecov.io/gh/apache/incubator-superset/pull/5376/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9sb2dnZXIuanM=) | `95.58% <ø> (ø)` | :arrow_up: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/5376/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | `100% <100%> (ø)` | :arrow_up: |
| [...plore/components/controls/FixedOrMetricControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5376/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvRml4ZWRPck1ldHJpY0NvbnRyb2wuanN4) | `88% <100%> (ø)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5376/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.67% <86.36%> (+0.32%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5376/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `78.13% <0%> (+0.79%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5376/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.83% <0%> (+0.93%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5376?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5376?src=pr&el=footer). Last update [bd47587...90d92c4](https://codecov.io/gh/apache/incubator-superset/pull/5376?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org