[GitHub] [spark] MaxGekk commented on a diff in pull request #38629: [SPARK-41072][SQL][SS] Add the error class `STREAM_FAILED` to `StreamingQueryException`

[GitBox <gi...@apache.org>]

MaxGekk commented on code in PR #38629:
URL: https://github.com/apache/spark/pull/38629#discussion_r1020856827


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala:
##########
@@ -320,16 +319,20 @@ abstract class StreamExecution(
         // This is a workaround for HADOOP-12074: `Shell.runCommand` converts `InterruptedException`
         // to `new IOException(ie.toString())` before Hadoop 2.8.
         updateStatusMessage("Stopped")
-      case t: Throwable =>
-        val e = QueryExecution.toInternalError(msg = s"Execution of the stream $name failed.", t)
+      case e: Throwable =>
+        val message = if (e.getMessage == null) "" else e.getMessage

Review Comment:
   I have to check the `null` because our code that substitutes parameters in error templates is not tolerant to `null`s. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org