You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by kw...@apache.org on 2017/04/28 19:28:17 UTC
[1/3] incubator-impala git commit: IMPALA-5245: Disable
buffer-allocator-test under ASAN
Repository: incubator-impala
Updated Branches:
refs/heads/master 6cddb952c -> 2e6375285
IMPALA-5245: Disable buffer-allocator-test under ASAN
Until we figure out the root cause, disable this test (which exercises
code that is under development and not yet enabled by default).
Change-Id: I4e685d4482d548cc3e724c20a83ae14890ce56ec
Reviewed-on: http://gerrit.cloudera.org:8080/6737
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/5294bb2d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/5294bb2d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/5294bb2d
Branch: refs/heads/master
Commit: 5294bb2d7a7733b4c5b3fae7a14498d85e87c90d
Parents: 6cddb95
Author: Dan Hecht <dh...@cloudera.com>
Authored: Wed Apr 26 14:59:32 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Thu Apr 27 06:27:08 2017 +0000
----------------------------------------------------------------------
be/src/runtime/bufferpool/buffer-allocator-test.cc | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/5294bb2d/be/src/runtime/bufferpool/buffer-allocator-test.cc
----------------------------------------------------------------------
diff --git a/be/src/runtime/bufferpool/buffer-allocator-test.cc b/be/src/runtime/bufferpool/buffer-allocator-test.cc
index 167298d..4aff720 100644
--- a/be/src/runtime/bufferpool/buffer-allocator-test.cc
+++ b/be/src/runtime/bufferpool/buffer-allocator-test.cc
@@ -177,6 +177,12 @@ TEST_F(SystemAllocatorTest, LargeAllocFailure) {
}
int main(int argc, char** argv) {
+#ifdef ADDRESS_SANITIZER
+ // These tests are disabled for address sanitizer builds.
+ // TODO: fix IMPALA-5245 and re-enable.
+ cerr << "Buffer Allocator Test Skipped (IMPALA-5245)" << endl;
+ return 0;
+#endif
::testing::InitGoogleTest(&argc, argv);
impala::InitCommonRuntime(argc, argv, true, impala::TestInfo::BE_TEST);
int result = 0;
[2/3] incubator-impala git commit: IMPALA-5253: Use appropriate
transport for StatestoreSubscriber
Posted by kw...@apache.org.
IMPALA-5253: Use appropriate transport for StatestoreSubscriber
This makes sure that the appropriate Thrift transport is used in
the StatestoreSubscriber.
This patch also adds a custom cluster test to improve our security
testing.
Change-Id: I711b994bd82533d2a6dfad3f4c103f7caecc427b
Reviewed-on: http://gerrit.cloudera.org:8080/6720
Reviewed-by: Sailesh Mukil <sa...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/1213843d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/1213843d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/1213843d
Branch: refs/heads/master
Commit: 1213843d54c79bcfbf613d3fd29a00b3e44e1151
Parents: 5294bb2
Author: Sailesh Mukil <sa...@cloudera.com>
Authored: Thu Mar 30 14:44:36 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Thu Apr 27 11:24:04 2017 +0000
----------------------------------------------------------------------
be/src/statestore/statestore-subscriber.cc | 10 ++++++++++
be/src/statestore/statestore.cc | 6 ++++--
2 files changed, 14 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/1213843d/be/src/statestore/statestore-subscriber.cc
----------------------------------------------------------------------
diff --git a/be/src/statestore/statestore-subscriber.cc b/be/src/statestore/statestore-subscriber.cc
index 28ac553..cb46e3b 100644
--- a/be/src/statestore/statestore-subscriber.cc
+++ b/be/src/statestore/statestore-subscriber.cc
@@ -48,6 +48,10 @@ DEFINE_int32(statestore_subscriber_cnxn_retry_interval_ms, 3000, "The interval,
"to wait between attempts to make an RPC connection to the statestore.");
DECLARE_string(ssl_client_ca_certificate);
+DECLARE_string(ssl_server_certificate);
+DECLARE_string(ssl_private_key);
+DECLARE_string(ssl_private_key_password_cmd);
+
namespace impala {
// Used to identify the statestore in the failure detector
@@ -189,7 +193,13 @@ Status StatestoreSubscriber::Start() {
heartbeat_server_.reset(new ThriftServer("StatestoreSubscriber", processor,
heartbeat_address_.port, NULL, NULL, 5));
+ if (EnableInternalSslConnections()) {
+ LOG(INFO) << "Enabling SSL for Statestore subscriber";
+ RETURN_IF_ERROR(heartbeat_server_->EnableSsl(FLAGS_ssl_server_certificate,
+ FLAGS_ssl_private_key, FLAGS_ssl_private_key_password_cmd));
+ }
RETURN_IF_ERROR(heartbeat_server_->Start());
+
LOG(INFO) << "Registering with statestore";
status = Register();
if (status.ok()) {
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/1213843d/be/src/statestore/statestore.cc
----------------------------------------------------------------------
diff --git a/be/src/statestore/statestore.cc b/be/src/statestore/statestore.cc
index 1b1034e..a19de2e 100644
--- a/be/src/statestore/statestore.cc
+++ b/be/src/statestore/statestore.cc
@@ -226,10 +226,12 @@ Statestore::Statestore(MetricGroup* metrics)
bind<void>(mem_fn(&Statestore::DoSubscriberUpdate), this, true, _1, _2)),
update_state_client_cache_(new ClientCache<StatestoreSubscriberClient>(1, 0,
FLAGS_statestore_update_tcp_timeout_seconds * 1000,
- FLAGS_statestore_update_tcp_timeout_seconds * 1000)),
+ FLAGS_statestore_update_tcp_timeout_seconds * 1000, "",
+ EnableInternalSslConnections())),
heartbeat_client_cache_(new ClientCache<StatestoreSubscriberClient>(1, 0,
FLAGS_statestore_heartbeat_tcp_timeout_seconds * 1000,
- FLAGS_statestore_heartbeat_tcp_timeout_seconds * 1000)),
+ FLAGS_statestore_heartbeat_tcp_timeout_seconds * 1000, "",
+ EnableInternalSslConnections())),
thrift_iface_(new StatestoreThriftIf(this)),
failure_detector_(new MissedHeartbeatFailureDetector(
FLAGS_statestore_max_missed_heartbeats,
[3/3] incubator-impala git commit: IMPALA-5257:
test_seq_writer_hive_compatibility fails on local file system build
Posted by kw...@apache.org.
IMPALA-5257: test_seq_writer_hive_compatibility fails on local file
system build
TestTableWriters.test_seq_writer_hive_compatibility test introduced in
IMPALA-3079 had to be skipped for non-HDFS filesystems.
Change-Id: Ic7dbe2529818865f871b66d78642ed956d1ee039
Reviewed-on: http://gerrit.cloudera.org:8080/6746
Reviewed-by: Michael Ho <kw...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/2e637528
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/2e637528
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/2e637528
Branch: refs/heads/master
Commit: 2e63752858d71cc745534367a686980e060a8180
Parents: 1213843
Author: Attila Jeges <at...@cloudera.com>
Authored: Thu Apr 27 13:46:36 2017 +0200
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Fri Apr 28 06:20:29 2017 +0000
----------------------------------------------------------------------
tests/query_test/test_compressed_formats.py | 3 +++
1 file changed, 3 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/2e637528/tests/query_test/test_compressed_formats.py
----------------------------------------------------------------------
diff --git a/tests/query_test/test_compressed_formats.py b/tests/query_test/test_compressed_formats.py
index 36dc427..efb2c2b 100644
--- a/tests/query_test/test_compressed_formats.py
+++ b/tests/query_test/test_compressed_formats.py
@@ -147,6 +147,9 @@ class TestTableWriters(ImpalaTestSuite):
def test_seq_writer(self, vector, unique_database):
self.run_test_case('QueryTest/seq-writer', vector, unique_database)
+ @SkipIfS3.hive
+ @SkipIfIsilon.hive
+ @SkipIfLocal.hive
def test_seq_writer_hive_compatibility(self, vector, unique_database):
self.client.execute('set ALLOW_UNSUPPORTED_FORMATS=1')
# Write sequence files with different compression codec/compression mode and then read