You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/28 05:34:33 UTC

[GitHub] [arrow] cyb70289 commented on a change in pull request #10602: ARROW-13173: [C++] TestAsyncUtil.ReadaheadFailed asserts occasionally

cyb70289 commented on a change in pull request #10602:
URL: https://github.com/apache/arrow/pull/10602#discussion_r659489752



##########
File path: cpp/src/arrow/util/async_generator_test.cc
##########
@@ -1095,40 +1095,51 @@ TEST(TestAsyncUtil, ReadaheadMove) {
 TEST(TestAsyncUtil, ReadaheadFailed) {
   ASSERT_OK_AND_ASSIGN(auto thread_pool, internal::ThreadPool::Make(4));
   std::atomic<int32_t> counter(0);
+  std::mutex mx;
+  bool error_unlocked = false;

Review comment:
       Is it possible to make this test simpler?
   I think this test is to verify failed readahead is detected, and won't interfere with successful readaheads.
   Can we keep original code, with minor changes to make sure `counter` is incrementing till `IterationEnd`, but allow `counter` to be large?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org