You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Reka Thirunavukkarasu <re...@wso2.com> on 2014/12/22 14:15:41 UTC
Incorrect application status tree when having more than one group instances
Hi Dakshika,
I have got the application deployment status as attached here with. It has
two group instances. But UI doesn't reflect it properly. I have attached
the screen shot. Am i missing anything?
Thanks,
Reka
--
Reka Thirunavukkarasu
Senior Software Engineer,
WSO2, Inc.:http://wso2.com,
Mobile: +94776442007
Re: Incorrect application status tree when having more than one group instances
Posted by Reka Thirunavukkarasu <re...@wso2.com>.
I have merged your pull request.
Thanks,
Reka
On Tue, Dec 23, 2014 at 11:54 AM, Dakshika Jayathilaka <da...@wso2.com>
wrote:
> Yep, thats the issue i found. when i'm generating tree i used instanceId
> so in this case it try to map with super parent.
>
> Anyway my last pull will fix above on visualizing. But need to verify.
>
> Thanks,
>
> *Dakshika Jayathilaka*
> Software Engineer
> WSO2, Inc.
> lean.enterprise.middleware
> 0771100911
>
> On Tue, Dec 23, 2014 at 10:38 AM, Reka Thirunavukkarasu <re...@wso2.com>
> wrote:
>
>> Thanks Dakshika for looking into this..It looks nice now..
>>
>> On Tue, Dec 23, 2014 at 9:45 AM, Dakshika Jayathilaka <da...@wso2.com>
>> wrote:
>>
>>> Hi Reka,
>>>
>>> I found the issue. issue arise when i set the parent node.
>>>
>>> Also i found small issue on JSON as wel. when we are setting
>>> *instanceId* for group which doesn't contain multiple instances. AFAIK
>>> it should set as <groupid>-<instance_no>
>>>
>>
>> Nope..This is not an issue. We usually generate group related instance id
>> only when the group has group scaling enabled..For other groups, it will
>> re-use the instanceId generated by the parent. In this sample, since
>> mygroup1 doesn't have group scaling enabled, it is using the same
>> instanceId of the parent which is appscaling-1.
>>
>> So, if someone needs a specific instanceId in the group level, they will
>> have to enable group scaling in the group definition.
>>
>> Thanks,
>> Reka
>>
>>>
>>>
>>> Fix added and seems its working fine now.
>>>
>>>
>>>
>>>
>>> sample preview on my stratos-editor repo :
>>> http://htmlpreview.github.io/?https://raw.githubusercontent.com/dakshika/stratos-app-editor/master/topologyinstance.html
>>>
>>>
>>> Here is the pull request for master
>>>
>>> https://github.com/apache/stratos/pull/163
>>>
>>>
>>> Thank you,
>>>
>>> Bst Regards,
>>>
>>> *Dakshika Jayathilaka*
>>> Software Engineer
>>> WSO2, Inc.
>>> lean.enterprise.middleware
>>> 0771100911
>>>
>>> On Tue, Dec 23, 2014 at 8:31 AM, Dakshika Jayathilaka <dakshika@wso2.com
>>> > wrote:
>>>
>>>> Hi,
>>>>
>>>> I'll check and update soon..
>>>>
>>>> *Dakshika Jayathilaka*
>>>> Software Engineer
>>>> WSO2, Inc.
>>>> lean.enterprise.middleware
>>>> 0771100911
>>>>
>>>> On Mon, Dec 22, 2014 at 6:45 PM, Reka Thirunavukkarasu <re...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi Dakshika,
>>>>>
>>>>> I have got the application deployment status as attached here with. It
>>>>> has two group instances. But UI doesn't reflect it properly. I have
>>>>> attached the screen shot. Am i missing anything?
>>>>>
>>>>> Thanks,
>>>>> Reka
>>>>>
>>>>> --
>>>>> Reka Thirunavukkarasu
>>>>> Senior Software Engineer,
>>>>> WSO2, Inc.:http://wso2.com,
>>>>> Mobile: +94776442007
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>>
>> --
>> Reka Thirunavukkarasu
>> Senior Software Engineer,
>> WSO2, Inc.:http://wso2.com,
>> Mobile: +94776442007
>>
>>
>>
>
--
Reka Thirunavukkarasu
Senior Software Engineer,
WSO2, Inc.:http://wso2.com,
Mobile: +94776442007
Re: Incorrect application status tree when having more than one group instances
Posted by Dakshika Jayathilaka <da...@wso2.com>.
Yep, thats the issue i found. when i'm generating tree i used instanceId so
in this case it try to map with super parent.
Anyway my last pull will fix above on visualizing. But need to verify.
Thanks,
*Dakshika Jayathilaka*
Software Engineer
WSO2, Inc.
lean.enterprise.middleware
0771100911
On Tue, Dec 23, 2014 at 10:38 AM, Reka Thirunavukkarasu <re...@wso2.com>
wrote:
> Thanks Dakshika for looking into this..It looks nice now..
>
> On Tue, Dec 23, 2014 at 9:45 AM, Dakshika Jayathilaka <da...@wso2.com>
> wrote:
>
>> Hi Reka,
>>
>> I found the issue. issue arise when i set the parent node.
>>
>> Also i found small issue on JSON as wel. when we are setting *instanceId*
>> for group which doesn't contain multiple instances. AFAIK it should set as
>> <groupid>-<instance_no>
>>
>
> Nope..This is not an issue. We usually generate group related instance id
> only when the group has group scaling enabled..For other groups, it will
> re-use the instanceId generated by the parent. In this sample, since
> mygroup1 doesn't have group scaling enabled, it is using the same
> instanceId of the parent which is appscaling-1.
>
> So, if someone needs a specific instanceId in the group level, they will
> have to enable group scaling in the group definition.
>
> Thanks,
> Reka
>
>>
>>
>> Fix added and seems its working fine now.
>>
>>
>>
>>
>> sample preview on my stratos-editor repo :
>> http://htmlpreview.github.io/?https://raw.githubusercontent.com/dakshika/stratos-app-editor/master/topologyinstance.html
>>
>>
>> Here is the pull request for master
>>
>> https://github.com/apache/stratos/pull/163
>>
>>
>> Thank you,
>>
>> Bst Regards,
>>
>> *Dakshika Jayathilaka*
>> Software Engineer
>> WSO2, Inc.
>> lean.enterprise.middleware
>> 0771100911
>>
>> On Tue, Dec 23, 2014 at 8:31 AM, Dakshika Jayathilaka <da...@wso2.com>
>> wrote:
>>
>>> Hi,
>>>
>>> I'll check and update soon..
>>>
>>> *Dakshika Jayathilaka*
>>> Software Engineer
>>> WSO2, Inc.
>>> lean.enterprise.middleware
>>> 0771100911
>>>
>>> On Mon, Dec 22, 2014 at 6:45 PM, Reka Thirunavukkarasu <re...@wso2.com>
>>> wrote:
>>>
>>>> Hi Dakshika,
>>>>
>>>> I have got the application deployment status as attached here with. It
>>>> has two group instances. But UI doesn't reflect it properly. I have
>>>> attached the screen shot. Am i missing anything?
>>>>
>>>> Thanks,
>>>> Reka
>>>>
>>>> --
>>>> Reka Thirunavukkarasu
>>>> Senior Software Engineer,
>>>> WSO2, Inc.:http://wso2.com,
>>>> Mobile: +94776442007
>>>>
>>>>
>>>>
>>>
>>
>
>
> --
> Reka Thirunavukkarasu
> Senior Software Engineer,
> WSO2, Inc.:http://wso2.com,
> Mobile: +94776442007
>
>
>
Re: Incorrect application status tree when having more than one group instances
Posted by Reka Thirunavukkarasu <re...@wso2.com>.
Thanks Dakshika for looking into this..It looks nice now..
On Tue, Dec 23, 2014 at 9:45 AM, Dakshika Jayathilaka <da...@wso2.com>
wrote:
> Hi Reka,
>
> I found the issue. issue arise when i set the parent node.
>
> Also i found small issue on JSON as wel. when we are setting *instanceId*
> for group which doesn't contain multiple instances. AFAIK it should set as
> <groupid>-<instance_no>
>
Nope..This is not an issue. We usually generate group related instance id
only when the group has group scaling enabled..For other groups, it will
re-use the instanceId generated by the parent. In this sample, since
mygroup1 doesn't have group scaling enabled, it is using the same
instanceId of the parent which is appscaling-1.
So, if someone needs a specific instanceId in the group level, they will
have to enable group scaling in the group definition.
Thanks,
Reka
>
>
> Fix added and seems its working fine now.
>
>
>
>
> sample preview on my stratos-editor repo :
> http://htmlpreview.github.io/?https://raw.githubusercontent.com/dakshika/stratos-app-editor/master/topologyinstance.html
>
>
> Here is the pull request for master
>
> https://github.com/apache/stratos/pull/163
>
>
> Thank you,
>
> Bst Regards,
>
> *Dakshika Jayathilaka*
> Software Engineer
> WSO2, Inc.
> lean.enterprise.middleware
> 0771100911
>
> On Tue, Dec 23, 2014 at 8:31 AM, Dakshika Jayathilaka <da...@wso2.com>
> wrote:
>
>> Hi,
>>
>> I'll check and update soon..
>>
>> *Dakshika Jayathilaka*
>> Software Engineer
>> WSO2, Inc.
>> lean.enterprise.middleware
>> 0771100911
>>
>> On Mon, Dec 22, 2014 at 6:45 PM, Reka Thirunavukkarasu <re...@wso2.com>
>> wrote:
>>
>>> Hi Dakshika,
>>>
>>> I have got the application deployment status as attached here with. It
>>> has two group instances. But UI doesn't reflect it properly. I have
>>> attached the screen shot. Am i missing anything?
>>>
>>> Thanks,
>>> Reka
>>>
>>> --
>>> Reka Thirunavukkarasu
>>> Senior Software Engineer,
>>> WSO2, Inc.:http://wso2.com,
>>> Mobile: +94776442007
>>>
>>>
>>>
>>
>
--
Reka Thirunavukkarasu
Senior Software Engineer,
WSO2, Inc.:http://wso2.com,
Mobile: +94776442007
Re: Incorrect application status tree when having more than one group instances
Posted by Dakshika Jayathilaka <da...@wso2.com>.
Hi Reka,
I found the issue. issue arise when i set the parent node.
Also i found small issue on JSON as wel. when we are setting *instanceId*
for group which doesn't contain multiple instances. AFAIK it should set as
<groupid>-<instance_no>
Fix added and seems its working fine now.
sample preview on my stratos-editor repo :
http://htmlpreview.github.io/?https://raw.githubusercontent.com/dakshika/stratos-app-editor/master/topologyinstance.html
Here is the pull request for master
https://github.com/apache/stratos/pull/163
Thank you,
Bst Regards,
*Dakshika Jayathilaka*
Software Engineer
WSO2, Inc.
lean.enterprise.middleware
0771100911
On Tue, Dec 23, 2014 at 8:31 AM, Dakshika Jayathilaka <da...@wso2.com>
wrote:
> Hi,
>
> I'll check and update soon..
>
> *Dakshika Jayathilaka*
> Software Engineer
> WSO2, Inc.
> lean.enterprise.middleware
> 0771100911
>
> On Mon, Dec 22, 2014 at 6:45 PM, Reka Thirunavukkarasu <re...@wso2.com>
> wrote:
>
>> Hi Dakshika,
>>
>> I have got the application deployment status as attached here with. It
>> has two group instances. But UI doesn't reflect it properly. I have
>> attached the screen shot. Am i missing anything?
>>
>> Thanks,
>> Reka
>>
>> --
>> Reka Thirunavukkarasu
>> Senior Software Engineer,
>> WSO2, Inc.:http://wso2.com,
>> Mobile: +94776442007
>>
>>
>>
>
Re: Incorrect application status tree when having more than one group instances
Posted by Dakshika Jayathilaka <da...@wso2.com>.
Hi,
I'll check and update soon..
*Dakshika Jayathilaka*
Software Engineer
WSO2, Inc.
lean.enterprise.middleware
0771100911
On Mon, Dec 22, 2014 at 6:45 PM, Reka Thirunavukkarasu <re...@wso2.com>
wrote:
> Hi Dakshika,
>
> I have got the application deployment status as attached here with. It has
> two group instances. But UI doesn't reflect it properly. I have attached
> the screen shot. Am i missing anything?
>
> Thanks,
> Reka
>
> --
> Reka Thirunavukkarasu
> Senior Software Engineer,
> WSO2, Inc.:http://wso2.com,
> Mobile: +94776442007
>
>
>