[GitHub] [hbase-thirdparty] busbey commented on a change in pull request #26: HBASE-24798 [hbase-thirdparty] Exclude module-info and SubmissionPubl…

[GitBox <gi...@apache.org>]

busbey commented on a change in pull request #26:
URL: https://github.com/apache/hbase-thirdparty/pull/26#discussion_r462995741



##########
File path: hbase-shaded-jersey/pom.xml
##########
@@ -106,6 +106,33 @@
           </execution>
         </executions>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-antrun-plugin</artifactId>
+        <version>3.0.0</version>
+        <executions>
+          <execution>
+            <id>unpack</id>

Review comment:
       A better ID here would be something like `relocate-jersy-jdk11-support`.
   
   Should also add a comment about what is going on since future maintainers might not already know about multi-release jars

##########
File path: pom.xml
##########
@@ -334,6 +335,10 @@
               <rules>
                 <enforceBytecodeVersion>
                   <maxJdkVersion>${compileSource}</maxJdkVersion>
+                  <ignoreClasses>
+                    <ignoreClass>module-info</ignoreClass>

Review comment:
       Note the jira key for the bug that means we have to exclude module info

##########
File path: pom.xml
##########
@@ -129,6 +129,7 @@
     <java.min.version>${compileSource}</java.min.version>
     <maven.min.version>3.3.3</maven.min.version>
     <rename.offset>org.apache.hbase.thirdparty</rename.offset>
+    <rename.offset.dir>org/apache/hbase/thirdparty</rename.offset.dir>

Review comment:
       Either a note that says it must match the package above or create it using the build-helper plugin to replace "." with "/"

##########
File path: pom.xml
##########
@@ -334,6 +335,10 @@
               <rules>
                 <enforceBytecodeVersion>
                   <maxJdkVersion>${compileSource}</maxJdkVersion>
+                  <ignoreClasses>
+                    <ignoreClass>module-info</ignoreClass>
+		    <ignoreClass>**.SubmissionPublisher*</ignoreClass>

Review comment:
       Can we scope this to specifically from Jersey? With a note that it has a multi-release jar?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org