[GitHub] [apisix] leslie-tsang commented on a diff in pull request #9341: chore(ci): remove 3rd keycloak docker image

["leslie-tsang (via GitHub)" <gi...@apache.org>]

leslie-tsang commented on code in PR #9341:
URL: https://github.com/apache/apisix/pull/9341#discussion_r1172006897


##########
ci/init-plugin-test-service.sh:
##########
@@ -42,8 +42,8 @@ after() {
 
     # wait for keycloak ready
     bash -c 'while true; do curl -s localhost:8080 &>/dev/null; ret=$?; [[ $ret -eq 0 ]] && break; sleep 3; done'
-    docker cp ci/kcadm_configure_cas.sh apisix_keycloak_new:/tmp/
-    docker exec apisix_keycloak_new bash /tmp/kcadm_configure_cas.sh
+    docker cp ci/kcadm_configure_cas.sh apisix_keycloak:/tmp/

Review Comment:
   Why don't we use volume feature to mount it ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org