You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/14 17:21:03 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #765: netutils/webclient: fix the fd leak during connect(2) fail

xiaoxiang781216 commented on a change in pull request #765:
URL: https://github.com/apache/incubator-nuttx-apps/pull/765#discussion_r651135745



##########
File path: netutils/webclient/webclient.c
##########
@@ -903,8 +903,7 @@ int webclient_perform(FAR struct webclient_context *ctx)
       if (ret < 0)
         {
           nerr("ERROR: connect failed: %d\n", errno);
-          free(ws);
-          return ret;
+          goto errout_with_errno;

Review comment:
       The code is changed recently, look like the leak is fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org