You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/01/04 08:42:10 UTC
Review Request 55164: AMBARI-19352 : Designer should always pick
latest version for an action node
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55164/
-----------------------------------------------------------
Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-19352
https://issues.apache.org/jira/browse/AMBARI-19352
Repository: ambari
Description
-------
Designer should always pick latest version for an action node and the actin node settings should be specific to each workflow tab.
But as of now, designer is picking up old settings even for a new tab.
Steps to reproduce:
1) Import a workflow with hive node and hive node version as 0.2.
2) Open a new tab and add a hive node to the new workflow.
3) Preview the xml for new workflow. Even the new workflow has hive version as 0.2. Ideally it should be the latest version 0.6.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 4ef0ac3
contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-version-settings.js 3bd6653
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 1d7f435
contrib/views/wfmanager/src/main/resources/ui/app/components/coord-version-settings.js 6385a44
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c6264ba
contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js 9103314
contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js af61c91
contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js 2714ca1
contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 76da535
contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js 0a5083f
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js d001f38
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js fa428bb
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js 012e7ac
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js f4fc20d
contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 10f745a
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 93a0541
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-version-settings.hbs 6d6f675
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs fff8c8c
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-version-settings.hbs be862ac
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 8438255
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 7449f27
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/version-settings.hbs 145f81b
contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs d52c893
Diff: https://reviews.apache.org/r/55164/diff/
Testing
-------
Manual
Thanks,
Padma Priya N
Re: Review Request 55164: AMBARI-19352 : Designer should always pick
latest version for an action node
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55164/#review160562
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Jan. 4, 2017, 8:42 a.m., Padma Priya N wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55164/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2017, 8:42 a.m.)
>
>
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-19352
> https://issues.apache.org/jira/browse/AMBARI-19352
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Designer should always pick latest version for an action node and the actin node settings should be specific to each workflow tab.
> But as of now, designer is picking up old settings even for a new tab.
> Steps to reproduce:
> 1) Import a workflow with hive node and hive node version as 0.2.
> 2) Open a new tab and add a hive node to the new workflow.
> 3) Preview the xml for new workflow. Even the new workflow has hive version as 0.2. Ideally it should be the latest version 0.6.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-config.js 4ef0ac3
> contrib/views/wfmanager/src/main/resources/ui/app/components/bundle-version-settings.js 3bd6653
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 1d7f435
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-version-settings.js 6385a44
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js c6264ba
> contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js 9103314
> contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js af61c91
> contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-importer.js 2714ca1
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js 76da535
> contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js 0a5083f
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js d001f38
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js fa428bb
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js 012e7ac
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js f4fc20d
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design.js 10f745a
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-config.hbs 93a0541
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/bundle-version-settings.hbs 6d6f675
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-config.hbs fff8c8c
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/coord-version-settings.hbs be862ac
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-errors.hbs 8438255
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs 7449f27
> contrib/views/wfmanager/src/main/resources/ui/app/templates/components/version-settings.hbs 145f81b
> contrib/views/wfmanager/src/main/resources/ui/app/templates/design.hbs d52c893
>
> Diff: https://reviews.apache.org/r/55164/diff/
>
>
> Testing
> -------
>
> Manual
>
>
> Thanks,
>
> Padma Priya N
>
>