[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #1036: IGNITE-17574 Fix assertion error ECATCHUP expected

[GitBox <gi...@apache.org>]

SammyVimes commented on code in PR #1036:
URL: https://github.com/apache/ignite-3/pull/1036#discussion_r955103139


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/RebalanceRaftGroupEventsListener.java:
##########
@@ -191,14 +191,19 @@ public void onReconfigurationError(Status status, List<PeerId> peers, long term)
         }
 
         try {
-            if (status == null) {
-                // leader stepped down, so we are expecting RebalanceRaftGroupEventsListener.onLeaderElected to be called on a new leader.
+            assert status != null;
+
+            RaftError raftError = status.getRaftError();
+
+            if (raftError == RaftError.EPERM && "Leader stepped down.".equals(status.getErrorMsg())) {

Review Comment:
   The idea was to not change JRaft code at all here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org