You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:41:43 UTC
[GitHub] [flink] zhuzhurk opened a new pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
zhuzhurk opened a new pull request #13884:
URL: https://github.com/apache/flink/pull/13884
## What is the purpose of the change
This PR is to remove legacy org.apache.flink.runtime.executiongraph.restart.RestartStrategy, all its implementations and usages.
It is based on #13883
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-720451080
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8793",
"triggerID" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8825",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9754",
"triggerID" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"triggerType" : "PUSH"
}, {
"hash" : "121f04a5b21f5591440b9e95c47f49b081b533e2",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10960",
"triggerID" : "121f04a5b21f5591440b9e95c47f49b081b533e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 121f04a5b21f5591440b9e95c47f49b081b533e2 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-720451080
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8793",
"triggerID" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8825",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9754",
"triggerID" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8aa0f9c13f6df568244db5edfbfa56df51c0e33 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8825) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814)
* 76d8fc44bd6f73200fd57f76cc3ebd64f176eb63 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9754)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-720451080
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8793",
"triggerID" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8825",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9754",
"triggerID" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"triggerType" : "PUSH"
}, {
"hash" : "121f04a5b21f5591440b9e95c47f49b081b533e2",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10960",
"triggerID" : "121f04a5b21f5591440b9e95c47f49b081b533e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d8fc44bd6f73200fd57f76cc3ebd64f176eb63 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9754)
* 121f04a5b21f5591440b9e95c47f49b081b533e2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10960)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-720645615
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-720451080
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8793",
"triggerID" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8825",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9754",
"triggerID" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d8fc44bd6f73200fd57f76cc3ebd64f176eb63 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9754)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-720451080
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-747573579
Thanks for reviewing @tillrohrmann
Merging this one which also includes commits of #13641 #13882 and #13883 which are approved as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk merged pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #13884:
URL: https://github.com/apache/flink/pull/13884
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-720451080
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8793",
"triggerID" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8825",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b8aa0f9c13f6df568244db5edfbfa56df51c0e33 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8825) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814)
* 76d8fc44bd6f73200fd57f76cc3ebd64f176eb63 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-720426912
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13884: [FLINK-19921][runtime] Remove legacy restart strategy
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13884:
URL: https://github.com/apache/flink/pull/13884#issuecomment-720451080
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8793",
"triggerID" : "93def52c04a85c0809ecacbcc54a0e85fc43c485",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"triggerType" : "PUSH"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8825",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "b8aa0f9c13f6df568244db5edfbfa56df51c0e33",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=8814",
"triggerID" : "720645615",
"triggerType" : "MANUAL"
}, {
"hash" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9754",
"triggerID" : "76d8fc44bd6f73200fd57f76cc3ebd64f176eb63",
"triggerType" : "PUSH"
}, {
"hash" : "121f04a5b21f5591440b9e95c47f49b081b533e2",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "121f04a5b21f5591440b9e95c47f49b081b533e2",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 76d8fc44bd6f73200fd57f76cc3ebd64f176eb63 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9754)
* 121f04a5b21f5591440b9e95c47f49b081b533e2 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org