You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/02/22 00:30:40 UTC

[GitHub] ccollins476ad opened a new pull request #1660: mempool_tests: Fix stack corruption bug

ccollins476ad opened a new pull request #1660: mempool_tests: Fix stack corruption bug
URL: https://github.com/apache/mynewt-core/pull/1660
 
 
   The "extended mempool" tests were causing stack corruption.  These tests registered mempools that were allocated on the stack and never unregistered them.  So, after these tests ran, the global mempool list contained some invalid entries.  Subsequently attempting to iterate or append to the list resulted in a crash or other unpredictable behavior.
   
   The solution is:
   1. Statically allocate the mempools.
   2. Always unregister the relevant mempool at the start of each test.
   
   This is now the non-extended tests are already implemented.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services