You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "nastra (via GitHub)" <gi...@apache.org> on 2023/09/14 12:40:14 UTC
[GitHub] [iceberg-go] nastra opened a new pull request, #5: Ignore IntelliJ files
nastra opened a new pull request, #5:
URL: https://github.com/apache/iceberg-go/pull/5
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-go] nastra commented on a diff in pull request #5: Ignore IntelliJ files
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #5:
URL: https://github.com/apache/iceberg-go/pull/5#discussion_r1325895957
##########
dev/.rat-excludes:
##########
@@ -2,4 +2,5 @@
.rat-excludes
LICENSE
NOTICE
-go.sum
\ No newline at end of file
+go.sum
+build
Review Comment:
In https://github.com/apache/iceberg/blob/master/dev/.rat-excludes#L8 we're ignoring the entire `build` folder (where the rat-results.txt lands), so we're probably ok to do the same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-go] nastra commented on a diff in pull request #5: Ignore IntelliJ files
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #5:
URL: https://github.com/apache/iceberg-go/pull/5#discussion_r1325895957
##########
dev/.rat-excludes:
##########
@@ -2,4 +2,5 @@
.rat-excludes
LICENSE
NOTICE
-go.sum
\ No newline at end of file
+go.sum
+build
Review Comment:
In https://github.com/apache/iceberg/blob/master/dev/.rat-excludes#L8 we're ignoring the entire `build` folder (where the RAT results lands), so we're probably ok to do the same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-go] nastra merged pull request #5: Ignore IntelliJ files
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #5:
URL: https://github.com/apache/iceberg-go/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org