[GitHub] [flink] Samrat002 commented on a diff in pull request #22308: [FLINK-31518][Runtime / REST] Fix StandaloneHaServices#getClusterRestEndpointLeaderRetreiver to return correct rest port

["Samrat002 (via GitHub)" <gi...@apache.org>]

Samrat002 commented on code in PR #22308:
URL: https://github.com/apache/flink/pull/22308#discussion_r1157953690


##########
flink-runtime/src/main/java/org/apache/flink/runtime/highavailability/nonha/standalone/StandaloneHaServices.java:
##########
@@ -134,9 +136,13 @@ public LeaderElectionService getJobManagerLeaderElectionService(JobID jobID) {
     }
 
     @Override
-    public LeaderRetrievalService getClusterRestEndpointLeaderRetriever() {
+    public LeaderRetrievalService getClusterRestEndpointLeaderRetriever()
+            throws UnknownHostException {
         synchronized (lock) {
             checkNotShutdown();
+            String clusterRestEndpointAddress =
+                    HighAvailabilityServicesUtils.getWebMonitorAddress(
+                            configuration, AddressResolution.NO_ADDRESS_RESOLUTION);

Review Comment:
   Thank you @elphastori ! i have moved it out of the lock. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org