You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by sravan-s <gi...@git.apache.org> on 2017/03/13 12:15:56 UTC
[GitHub] zeppelin pull request #2128: [WIP] [Discuss] Make use of all grouped data to...
GitHub user sravan-s opened a pull request:
https://github.com/apache/zeppelin/pull/2128
[WIP] [Discuss] Make use of all grouped data to draw pie chart
### What is this PR for?
Now, grouped pie charts only uses the data from the first group
With this fix-
* Add data from all groups to variable d3g, so all groups could be rendered
* Rewrite for loop with map and concat
* Refactor some variables to const and let
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2237](https://issues.apache.org/jira/browse/ZEPPELIN-2237)
### How should this be tested?
* Create a built in pie chart visualization
* Select a column to group the data
* Should display the visualization based on all the available grouped data
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2237-grouped-piechart
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2128
----
commit 652c943c86373ba1c2f7efd0ed950b8ba56db18e
Author: ess_ess <sr...@gmail.com>
Date: 2017-03-10T03:49:55Z
Make use of all grouped data to draw pie chart
* Add data from all groups to variable d3g
* Rewrite for loop with map and concat
* Refactor some variables to const and let
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2128: [WIP] [Discuss] Make use of all grouped data to draw p...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2128
@Leemoonsoo Please review https://github.com/apache/zeppelin/pull/2132 . I came across it while working on this. I believe it should be hadled first
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2128: [WIP] [Discuss] Make use of all grouped data to...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2128: [WIP] [Discuss] Make use of all grouped data to draw p...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2128
As per [ZEPPELIN-2237](https://issues.apache.org/jira/browse/ZEPPELIN-2237), in situations in which data is grouped, the pie chart only displays the data from first group. With this fix, data from all the groups would be displayed in the pie chart
## Discuss
I would prefer to see pie chart with broken slices: https://www.amcharts.com/demos/pie-chart-broken-slices/. Not sure if nvd3 supports this feature. I won't suggest bringing in a new charting library to implement such an idea. Thoughts...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2128: [WIP] [Discuss] Make use of all grouped data to draw p...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s commented on the issue:
https://github.com/apache/zeppelin/pull/2128
@Leemoonsoo @AhyoungRyu Any comments on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2128: [WIP] [Discuss] Make use of all grouped data to...
Posted by sravan-s <gi...@git.apache.org>.
Github user sravan-s closed the pull request at:
https://github.com/apache/zeppelin/pull/2128
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2128: [WIP] [Discuss] Make use of all grouped data to draw p...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2128
LGTM and merge to master and branch-0.7 if no more comment
Thanks @sravan-s for the fix!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2128: [WIP] [Discuss] Make use of all grouped data to...
Posted by sravan-s <gi...@git.apache.org>.
GitHub user sravan-s reopened a pull request:
https://github.com/apache/zeppelin/pull/2128
[WIP] [Discuss] Make use of all grouped data to draw pie chart
### What is this PR for?
Now, grouped pie charts only uses the data from the first group
With this fix-
* Add data from all groups to variable d3g, so all groups could be rendered
* Rewrite for loop with map and concat
* Refactor some variables to const and let
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-2237](https://issues.apache.org/jira/browse/ZEPPELIN-2237)
### How should this be tested?
* Create a built in pie chart visualization
* Select a column to group the data
* Should display the visualization based on all the available grouped data
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2237-grouped-piechart
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2128
----
commit 652c943c86373ba1c2f7efd0ed950b8ba56db18e
Author: ess_ess <sr...@gmail.com>
Date: 2017-03-10T03:49:55Z
Make use of all grouped data to draw pie chart
* Add data from all groups to variable d3g
* Rewrite for loop with map and concat
* Refactor some variables to const and let
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---