You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by co...@jakarta.apache.org on 2004/08/31 11:22:20 UTC

[jira] Closed: (JELLY-77) [patch] Update jelly:util replace tag to replace entire strings

Message:

   The following issue has been closed.

   Resolver: dion gillard
       Date: Tue, 31 Aug 2004 2:20 AM

Committed
---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/JELLY-77

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: JELLY-77
    Summary: [patch] Update jelly:util replace tag to replace entire strings
       Type: Improvement

     Status: Closed
   Priority: Major
 Resolution: FIXED

    Project: jelly
 Components: 
             taglib.util
   Fix Fors:
             1.0-beta-4

   Assignee: 
   Reporter: Paul O'Fallon

    Created: Sun, 24 Aug 2003 2:25 PM
    Updated: Tue, 31 Aug 2004 2:20 AM
Environment: win xp, jdk1.3.1

Description:
The replace tag documentation indicates that it replaces "occurrances of strings", but the code only replaces instances of the first character in the old string with the first character in the new string.  It also does not accept an empty string as the new string.  I have a patch that updates the replace tag to replace whole strings, as well as accept empty strings, available here:
http://home.earthlink.net/~ofallon/patches/jelly-util-diff.txt
it updates both the code and the project.xml file to add a dependency on commons-lang.  All of the existing util tag tests still passed after making this change.

If this change is implemented, it may also make sense to change the attributes "oldChar" and "newChar" to just "old" and "new", but I'll leave decision that up to someone else :-)

Thanks,
Paul


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org