You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/16 04:56:25 UTC
[GitHub] [dubbo-go-samples] justxuewei commented on a change in pull request #298: fix rpc/jsonrpc
justxuewei commented on a change in pull request #298:
URL: https://github.com/apache/dubbo-go-samples/pull/298#discussion_r749899153
##########
File path: rpc/jsonrpc/java-client/pom.xml
##########
@@ -188,51 +188,64 @@
<build>
<plugins>
<plugin>
- <groupId>org.codehaus.mojo</groupId>
- <artifactId>exec-maven-plugin</artifactId>
- <version>3.0.0</version>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>3.1</version>
<configuration>
- <mainClass>com.alibaba.dubbo.container.Main</mainClass>
+ <source>8</source>
+ <target>8</target>
</configuration>
</plugin>
- <plugin>
- <artifactId>maven-dependency-plugin</artifactId>
- <executions>
- <execution>
- <id>unpack</id>
- <phase>package</phase>
- <goals>
- <goal>unpack</goal>
- </goals>
- <configuration>
- <artifactItems>
- <artifactItem>
- <groupId>com.alibaba</groupId>
- <artifactId>dubbo</artifactId>
- <version>${dubbo-version}</version>
- <outputDirectory>${project.build.directory}/dubbo</outputDirectory>
- <includes>META-INF/assembly/**</includes>
- </artifactItem>
- </artifactItems>
- </configuration>
- </execution>
- </executions>
- </plugin>
- <plugin>
- <artifactId>maven-assembly-plugin</artifactId>
- <configuration>
- <descriptor>src/main/assembly/assembly.xml</descriptor>
- </configuration>
- <executions>
- <execution>
- <id>make-assembly</id>
- <phase>package</phase>
- <goals>
- <goal>single</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
</plugins>
</build>
+<!-- <build>-->
+<!-- <plugins>-->
+<!-- <plugin>-->
+<!-- <groupId>org.codehaus.mojo</groupId>-->
+<!-- <artifactId>exec-maven-plugin</artifactId>-->
+<!-- <version>3.0.0</version>-->
+<!-- <configuration>-->
+<!-- <mainClass>com.alibaba.dubbo.container.Main</mainClass>-->
+<!-- </configuration>-->
+<!-- </plugin>-->
+<!-- <plugin>-->
+<!-- <artifactId>maven-dependency-plugin</artifactId>-->
+<!-- <executions>-->
+<!-- <execution>-->
+<!-- <id>unpack</id>-->
+<!-- <phase>package</phase>-->
+<!-- <goals>-->
+<!-- <goal>unpack</goal>-->
+<!-- </goals>-->
+<!-- <configuration>-->
+<!-- <artifactItems>-->
+<!-- <artifactItem>-->
+<!-- <groupId>com.alibaba</groupId>-->
+<!-- <artifactId>dubbo</artifactId>-->
+<!-- <version>${dubbo-version}</version>-->
+<!-- <outputDirectory>${project.build.directory}/dubbo</outputDirectory>-->
+<!-- <includes>META-INF/assembly/**</includes>-->
+<!-- </artifactItem>-->
+<!-- </artifactItems>-->
+<!-- </configuration>-->
+<!-- </execution>-->
+<!-- </executions>-->
+<!-- </plugin>-->
+<!-- <plugin>-->
+<!-- <artifactId>maven-assembly-plugin</artifactId>-->
+<!-- <configuration>-->
+<!-- <descriptor>src/main/assembly/assembly.xml</descriptor>-->
+<!-- </configuration>-->
+<!-- <executions>-->
+<!-- <execution>-->
+<!-- <id>make-assembly</id>-->
+<!-- <phase>package</phase>-->
+<!-- <goals>-->
+<!-- <goal>single</goal>-->
+<!-- </goals>-->
+<!-- </execution>-->
+<!-- </executions>-->
+<!-- </plugin>-->
+<!-- </plugins>-->
+<!-- </build>-->
</project>
Review comment:
If the code is useless, please consider removing it directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org