You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "reta (via GitHub)" <gi...@apache.org> on 2023/04/05 15:19:07 UTC
[GitHub] [flink-connector-opensearch] reta opened a new pull request, #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
reta opened a new pull request, #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16
Fixing the compilation issue for 1.18 (see please https://github.com/apache/flink-connector-opensearch/actions/runs/4615625503/jobs/8159702829).
```
Error: /home/runner/work/flink-connector-opensearch/flink-connector-opensearch/flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/OpensearchUtil.java:[144,19] org.apache.flink.connector.opensearch.OpensearchUtil.MockContext is not abstract and does not override abstract method getTargetColumns() in org.apache.flink.table.connector.sink.DynamicTableSink.Context
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162826956
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
Missed that, updated both to `1.17.1`. I think the snapshots (fe `1.18-SNAPSHOT`) are only for weekly builds (since this is very unstable target).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#issuecomment-1503618001
> LGTM
Thanks a lot, may I ask you please to trigger nightly action manually when you have an opportunity, thank you (once it is green, I will replicate changes to Elasticsearch connector)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162829801
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
Hm ... there is no 1.17.1 yet ...,
```
Run wget -q -c https://archive.apache.org/dist/flink/flink-1.17.1/flink-1.17.1-bin-scala_2.12.tgz -O - | tar -xz
wget -q -c https://archive.apache.org/dist/flink/flink-1.17.1/flink-1.17.1-bin-scala_2.12.tgz -O - | tar -xz
shell: /usr/bin/bash -e {0}
env:
MVN_COMMON_OPTIONS: -U -B --no-transfer-progress -Dflink.version=1.17.1
MVN_CONNECTION_OPTIONS: -Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false -Dmaven.wagon.httpconnectionManager.ttlSeconds=120
FLINK_CACHE_DIR: /tmp/cache/flink
MVN_BUILD_OUTPUT_FILE: /tmp/mvn_build_output.out
MVN_VALIDATION_DIR: /tmp/flink-validation-deployment
JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/8.0.362-9/x64
JAVA_HOME_8_X64: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/8.0.362-9/x64
MVN_DEPENDENCY_CONVERGENCE: -Dflink.convergence.phase=install -Pcheck-convergence
binary_url: https://archive.apache.org/dist/flink/flink-1.17.1/flink-1.17.1-bin-scala_2.12.tgz
cache_binary: true
gzip: stdin: unexpected end of file
tar: Child returned status 1
tar: Error is not recoverable: exiting now
Error: Process completed with exit code 2.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162816269
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
I actually think you need to add `.github/workflows/push_pr.yml` to set the Flink version either to a matrix (with Flink 1.17.1 and potentially Flink 1.18-SNAPSHOT), or at least that version should be updated to 1.17.1 :)
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
I actually think you need to update `.github/workflows/push_pr.yml` to set the Flink version either to a matrix (with Flink 1.17.1 and potentially Flink 1.18-SNAPSHOT), or at least that version should be updated to 1.17.1 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1159891707
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
> I was actually expecting that there was an Opensearch v3.0 branch, given that it has been released. Perhaps it makes sense to still create that.
May I ask you please to brach off v3.0? I believe I have no permissions to do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser merged pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser merged PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1158673505
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
@MartijnVisser @snuyanzin I was not able to make the nightly e2e tests to run across all three versions (the changes in `ExecutionConfig` are resulting in NPEs all over the place for `1.16-SNAPSHOT`), I had to drop it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1163012687
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
> I'll fix this afterwards :)
I'm an idiot and got confused by Flink 1.16.1, there's no Flink 1.17.1 yet 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1159391470
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
> The thing i would like to clarify whether it's ok to drop support for 1.16 while it's still maintained in main flink repo?
> @MartijnVisser may be you have more info about this ?
It's up to the maintainers to decide how you want to support two versions of Flink.
I was actually expecting that there was an Opensearch v3.0 branch, given that it has been released. Perhaps it makes sense to still create that.
I think if you would do that, you could follow the first example from https://cwiki.apache.org/confluence/display/FLINK/Externalized+Connector+development#ExternalizedConnectordevelopment-Examples
That would make it possible to drop support for 1.16 in this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1163061352
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
No worries at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1158673505
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
@MartijnVisser @snuyanzin I was not able to make the nightly e2e tests to run across all three versions (the changes in `ExecutionConfig` are resulting in NPEs all over the place for `1.16-SNAPSHOT`), I had to drop it. For the full context:
In 1.16 `ExecutionConfig` used to have `executionMode` field which is gone in 1.17+, the (de)serialization of the `ExecutionConfig` breaks loose since the 1.17 does not include it and 1.16 gets `null` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1159923772
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
> May I ask you please to brach off v3.0? I believe I have no permissions to do that
Sure. Do you want it to match the tag of the 3.0 release, or are there more commits that should be in there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162830988
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
Moved it back to 1.17.0 ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#issuecomment-1503642528
> may I ask you please to trigger nightly action manually
https://github.com/apache/flink-connector-opensearch/actions/runs/4669419298 is started!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162810174
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
Thanks a lot @MartijnVisser , rebased, I think we are good to go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "reta (via GitHub)" <gi...@apache.org>.
reta commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1160093049
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
I think d40b74ddba3cdaccfb45880aa0080d31dfa1e971 is good branching point (in case we would need to do another release), but it seem like the version should be 1.0.0 (not 3.0.0), and the main will become 2.0.0, is my understanding correct? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162981670
##########
.github/workflows/release.yml:
##########
@@ -24,7 +24,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16.1, 1.17.0]
+ flink: [1.17.0]
Review Comment:
I'll fix this afterwards :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] MartijnVisser commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "MartijnVisser (via GitHub)" <gi...@apache.org>.
MartijnVisser commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1162751592
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
@reta I've created [v1.0 ](https://github.com/apache/flink-connector-opensearch/tree/v1.0) and also set the version for `main` to `2.0-SNAPSHOT`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-connector-opensearch] snuyanzin commented on a diff in pull request #16: [hotfix] Fix nightly build for 1.18-SNAPSHOT, drop 1.16-SNAPSHOT from the nightly matrix
Posted by "snuyanzin (via GitHub)" <gi...@apache.org>.
snuyanzin commented on code in PR #16:
URL: https://github.com/apache/flink-connector-opensearch/pull/16#discussion_r1159385705
##########
.github/workflows/weekly.yml:
##########
@@ -26,7 +26,7 @@ jobs:
if: github.repository_owner == 'apache'
strategy:
matrix:
- flink: [1.16-SNAPSHOT, 1.17-SNAPSHOT, 1.18-SNAPSHOT]
Review Comment:
Looks reasonable.
The thing i would like to clarify whether it's ok to drop support for 1.16 while it's still maintained in main flink repo?
@MartijnVisser may be you have more info about this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org