You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fesod.apache.org by "bengbengbalabalabeng (via GitHub)" <gi...@apache.org> on 2026/08/10 12:08:08 UTC
[PR] refactor: make objects immutable and remove redundant methods [fesod]
bengbengbalabalabeng opened a new pull request, #1002:
URL: https://github.com/apache/fesod/pull/1002
<!--
Thanks very much for contributing to Apache Fesod (Incubating)! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
Closed: #ISSUE
Related: #ISSUE
-->
## Purpose of the pull request
As title.
## What's changed?
- Remove some unused Lombok annotations.
- Refactor these classes with only read-only properties into immutable objects.
## Checklist
- [x] I have read the [Contributor Guide](https://fesod.apache.org/community/contribution/).
- [ ] I have written the necessary doc or comment.
- [x] I have added the necessary unit tests and all cases have passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] refactor: make objects immutable and remove redundant methods [fesod]
Posted by "alaahong (via GitHub)" <gi...@apache.org>.
alaahong commented on PR #1002:
URL: https://github.com/apache/fesod/pull/1002#issuecomment-5305673988
generally good, do we have the possible to mark as @Deprecated for setter and propose to remove since a future version to avoid breaking change on existing usage?
And meanwhile ,for the unit test, can we add more dedicated case on the immutable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org
Re: [PR] refactor: make objects immutable and remove redundant methods [fesod]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #1002:
URL: https://github.com/apache/fesod/pull/1002#discussion_r3790871613
##########
fesod-sheet/src/test/java/org/apache/fesod/sheet/write/style/SheetFreezePaneStrategyTest.java:
##########
@@ -63,17 +62,6 @@ void constructor_acceptsPositiveValues() {
Assertions.assertDoesNotThrow(() -> new SheetFreezePaneStrategy(2, 3, 4, 5));
}
Review Comment:
The `SheetFreezePaneStrategy(SheetFreezePaneProperty)` constructor is still present, but the unit test that exercised it was removed. This leaves the property-based constructor untested after the `SheetFreezePaneProperty` immutability refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@fesod.apache.org
For additional commands, e-mail: commits-help@fesod.apache.org