[GitHub] [maven-release] michael-o commented on a diff in pull request #120: [MRELEASE-1088] Remove parsing of CLI arguments

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #120:
URL: https://github.com/apache/maven-release/pull/120#discussion_r866738102


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/InvokerMavenExecutor.java:
##########
@@ -379,17 +97,18 @@ public void executeGoals( File workingDirectory, List<String> goals, ReleaseEnvi
                 throw new MavenExecutorException( "Could not create temporary file for release settings.xml", e );
             }
         }
+
         try
         {
-            File localRepoDir = releaseEnvironment.getLocalRepositoryDirectory();
-            if ( localRepoDir != null )
+            List<String> targetGoals = new ArrayList<>( goals );
+
+            if ( additionalArguments != null && !additionalArguments.isEmpty() )
             {
-                req.setLocalRepositoryDirectory( localRepoDir );
+                // additionalArguments will be parsed be MavenInvoker
+                targetGoals.add( additionalArguments );

Review Comment:
   Not related to this, but `InvocatoinRequest` needs to rename `#setGoals()` to `#setArgs()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org