You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2013/06/07 16:23:24 UTC

[Bug 55073] New: wasted work in ValidateVisitor.isExpression()

https://issues.apache.org/bugzilla/show_bug.cgi?id=55073

            Bug ID: 55073
           Summary: wasted work in ValidateVisitor.isExpression()
           Product: Tomcat 7
           Version: 7.0.40
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Jasper
          Assignee: dev@tomcat.apache.org
          Reporter: nistor1@illinois.edu

Created attachment 30404
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=30404&action=edit
patch

The problem appears in version 7.0.40 and in revision 1490425.  I
attached a two-line patch that fixes it.

In method "ValidateVisitor.isExpression", the loop over "nodes" should
break immediately after "elExpression" is set to "true".  All the
iterations after "elExpression" is set to "true" do not perform any
useful work, at best they just set "elExpression" again to "true".

Method "startInternal" in class "StandardHost" has a similar loop
(over "valves"), and this loop breaks immediately after "found" is set
to "true", just like in the proposed patch.  Other methods (e.g.,
"MapperListener.findDefaultHost", "CollectVisitor.checkSeen",
"JspDocumentParser.processChars", "ParameterParser.isOneOf") also have
similar loops with similar breaks, just like in the proposed patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 55073] wasted work in ValidateVisitor.isExpression()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55073

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
Thanks for the patch. It has been applied to trunk and 7.0.x and will be
included in 7.0.42 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 55073] wasted work in ValidateVisitor.isExpression()

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55073

Adrian Nistor <ni...@illinois.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable
                 CC|                            |nistor1@illinois.edu

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org