You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/08/04 09:41:28 UTC
[GitHub] [activemq-nms-amqp] michaelandrepearce commented on a change in pull request #70: Amqnet 723
michaelandrepearce commented on a change in pull request #70:
URL: https://github.com/apache/activemq-nms-amqp/pull/70#discussion_r682457258
##########
File path: docs/configuration.md
##########
@@ -23,6 +23,7 @@ The options apply to the behavior of the NMS objects such as Connection, Session
- **nms.requestTimeout** Timeout value that controls how long the client waits on completion of various synchronous interactions, such as opening a producer or consumer, before returning an error. Does not affect synchronous message sends. By default the client will wait indefinitely for a request to complete.
- **nms.clientIdPrefix** Optional prefix value that is used for generated Client ID values when a new Connection is created for the JMS ConnectionFactory. The default prefix is 'ID:'.
- **nms.connectionIdPrefix** Optional prefix value that is used for generated Connection ID values when a new Connection is created for the JMS ConnectionFactory. This connection ID is used when logging some information from the JMS Connection object so a configurable prefix can make breadcrumbing the logs easier. The default prefix is 'ID:'.
+- **nms.maxMessageSize** Optional, specifies maximum message size (body) to be accepted for send. If its bigger, exeception would be thrown. The default value is 0 which means no limit.
Review comment:
Can we please use -1 to mean no limt.
##########
File path: docs/configuration.md
##########
@@ -23,6 +23,7 @@ The options apply to the behavior of the NMS objects such as Connection, Session
- **nms.requestTimeout** Timeout value that controls how long the client waits on completion of various synchronous interactions, such as opening a producer or consumer, before returning an error. Does not affect synchronous message sends. By default the client will wait indefinitely for a request to complete.
- **nms.clientIdPrefix** Optional prefix value that is used for generated Client ID values when a new Connection is created for the JMS ConnectionFactory. The default prefix is 'ID:'.
- **nms.connectionIdPrefix** Optional prefix value that is used for generated Connection ID values when a new Connection is created for the JMS ConnectionFactory. This connection ID is used when logging some information from the JMS Connection object so a configurable prefix can make breadcrumbing the logs easier. The default prefix is 'ID:'.
+- **nms.maxMessageSize** Optional, specifies maximum message size (body) to be accepted for send. If its bigger, exeception would be thrown. The default value is 0 which means no limit.
Review comment:
Can we please use -1 to mean no limit. to keep aligned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org