[GitHub] [kafka] lucasbru opened a new pull request, #12648: MINOR: Fixes in release.py

[GitBox <gi...@apache.org>]

lucasbru opened a new pull request, #12648:
URL: https://github.com/apache/kafka/pull/12648

   1) Permissions set incorrectly, probably because it used incorrect python3 syntax 
   (octals should use 0o prefix).
   
   2) JAVA_HOME logic didn't seem to hold up to its promise. The original logic was broken when user input was empty. It was supposed to use `JAVA_HOME` system property to find java, but it wouldn't set `jdk_java_home`, so the following version check 
   
   ```
   java_version = cmd_output("%s/bin/java -version" % jdk_java_home, env=jdk_env)
   ```
   
   would access `/bin/java` which does not exist on any system I know.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cadonna merged pull request #12648: MINOR: Fixes in release.py

[GitBox <gi...@apache.org>]

cadonna merged PR #12648:
URL: https://github.com/apache/kafka/pull/12648


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org