[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #5110: net/devif: allocate devif callback dynamically

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #5110:
URL: https://github.com/apache/incubator-nuttx/pull/5110#discussion_r776694408



##########
File path: net/devif/devif_callback.c
##########
@@ -258,11 +235,31 @@ FAR struct devif_callback_s *
                        FAR struct devif_callback_s **list_tail)
 {
   FAR struct devif_callback_s *ret;
+  int i;
 
   /* Check the head of the free list */
 
   net_lock();
-  ret  = g_cbfreelist;
+  ret = g_cbfreelist;
+
+  /* Allocate the callback entry from heap */

Review comment:
       @anchao can you please add part of https://github.com/apache/incubator-nuttx/pull/5110#issuecomment-1002741733 as an explanation here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org