Re: Review Request 20007: CLOUDSTACK-2697 - Populated the clusterId with actual value instead of Null in the alert message logs

[ASF Subversion and Git Services <as...@urd.zones.apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20007/#review42165
-----------------------------------------------------------


Commit 0babb92d62c08afc04aa0df1bbf053539a53c523 in cloudstack's branch refs/heads/master from Girish Chaudhari
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=0babb92 ]

CLOUDSTACK-2697 Removed the clusterId as null from the alert message logs

Signed-off-by: Daan Hoogland <da...@onecht.net>


- ASF Subversion and Git Services


On April 3, 2014, 4:49 p.m., Girish Chaudhari wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20007/
> -----------------------------------------------------------
> 
> (Updated April 3, 2014, 4:49 p.m.)
> 
> 
> Review request for cloudstack and prashant mishra.
> 
> 
> Bugs: CLOUDSTACK-2697
>     https://issues.apache.org/jira/browse/CLOUDSTACK-2697
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-2697 - cluster id in alert message is null {alertType:: 1 // dataCenterId:: 1 // podId:: 1 // clusterId:: null }
> 
> The Cluster ID is getting populated as null in the logs for the alert messages. In the code base the ClusterId has been hardcoded as null for the log messages. I have modified to code to provide the actual cluster ID. 
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/alert/AlertManagerImpl.java 2a343d5 
> 
> Diff: https://reviews.apache.org/r/20007/diff/
> 
> 
> Testing
> -------
> 
> Tested on the 4.3 platform. 
> 
> 
> Thanks,
> 
> Girish Chaudhari
> 
>