You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by Chris Mattmann <ma...@apache.org> on 2014/11/04 06:16:36 UTC
Review Request 27562: GRIB Parser for TIKA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/
-----------------------------------------------------------
Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
Bugs: tika-1423
https://issues.apache.org/jira/browse/tika-1423
Repository: tika
Description
-------
GRIB Parser Patch
Diffs
-----
./trunk/tika-parsers/pom.xml 1636144
./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
Diff: https://reviews.apache.org/r/27562/diff/
Testing
-------
update for #27414
Thanks,
Chris Mattmann
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Vineet Ghatge Hemantkumar <he...@usc.edu>.
> On Nov. 4, 2014, 5:45 a.m., Lewis McGibbney wrote:
> > OK, test is also failing for me with Tika trunk as follows
> >
> > 1 -------------------------------------------------------------------------------
> > 2 Test set: org.apache.tika.parser.grib.GribParserTest
> > 3 -------------------------------------------------------------------------------
> > 4 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.076 sec <<< FAILURE!
> > 5 testParseGlobalMetadata(org.apache.tika.parser.grib.GribParserTest) Time elapsed: 0.075 sec <<< ERROR!
> > 6 org.apache.tika.exception.TikaException: NetCDF parse error
> > 7 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:134)
> > 8 at org.apache.tika.parser.grib.GribParserTest.testParseGlobalMetadata(GribParserTest.java:52)
> > 9 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > 10 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > 11 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > 12 at java.lang.reflect.Method.invoke(Method.java:606)
> > 13 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > 14 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > 15 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > 16 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> > 17 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > 18 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > 19 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > 20 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > 21 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > 22 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > 23 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > 24 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > 25 at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > 26 at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > 27 at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > 28 at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > 29 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > 30 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > 31 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > 32 at java.lang.reflect.Method.invoke(Method.java:606)
> > 33 at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > 34 at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > 35 at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > 36 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > 37 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > 38 Caused by: java.io.IOException: Cant read gdas1.forecmwf.2014062612.grib2: not a valid CDM file.
> > 39 at ucar.nc2.NetcdfFile.open(NetcdfFile.java:803)
> > 40 at ucar.nc2.NetcdfFile.openInMemory(NetcdfFile.java:719)
> > 41 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:86)
> > 42 ... 30 more
> >
> > We need to do more work here, also there are a number of issue which need to be addressed and carried over from th previous issue I feel.
>
> Vineet Ghatge Hemantkumar wrote:
> I will see why its failing.
In the patch, I see that metadata.set(Metadata.RESOURCE_NAME_KEY, "gdas1.forecmwf.2014062612.grib2"); this shoudl be the following
metadata.set(Metadata.RESOURCE_NAME_KEY, "/test-documents/gdas1.forecmwf.2014062612.grib2");
- Vineet Ghatge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review59734
-----------------------------------------------------------
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Vineet Ghatge Hemantkumar <he...@usc.edu>.
> On Nov. 4, 2014, 5:45 a.m., Lewis McGibbney wrote:
> > OK, test is also failing for me with Tika trunk as follows
> >
> > 1 -------------------------------------------------------------------------------
> > 2 Test set: org.apache.tika.parser.grib.GribParserTest
> > 3 -------------------------------------------------------------------------------
> > 4 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.076 sec <<< FAILURE!
> > 5 testParseGlobalMetadata(org.apache.tika.parser.grib.GribParserTest) Time elapsed: 0.075 sec <<< ERROR!
> > 6 org.apache.tika.exception.TikaException: NetCDF parse error
> > 7 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:134)
> > 8 at org.apache.tika.parser.grib.GribParserTest.testParseGlobalMetadata(GribParserTest.java:52)
> > 9 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > 10 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > 11 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > 12 at java.lang.reflect.Method.invoke(Method.java:606)
> > 13 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > 14 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > 15 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > 16 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> > 17 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > 18 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > 19 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > 20 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > 21 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > 22 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > 23 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > 24 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > 25 at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > 26 at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > 27 at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > 28 at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > 29 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > 30 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > 31 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > 32 at java.lang.reflect.Method.invoke(Method.java:606)
> > 33 at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > 34 at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > 35 at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > 36 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > 37 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > 38 Caused by: java.io.IOException: Cant read gdas1.forecmwf.2014062612.grib2: not a valid CDM file.
> > 39 at ucar.nc2.NetcdfFile.open(NetcdfFile.java:803)
> > 40 at ucar.nc2.NetcdfFile.openInMemory(NetcdfFile.java:719)
> > 41 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:86)
> > 42 ... 30 more
> >
> > We need to do more work here, also there are a number of issue which need to be addressed and carried over from th previous issue I feel.
I will see why its failing.
- Vineet Ghatge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review59734
-----------------------------------------------------------
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Vineet Ghatge Hemantkumar <he...@usc.edu>.
> On Nov. 4, 2014, 5:45 a.m., Lewis McGibbney wrote:
> > OK, test is also failing for me with Tika trunk as follows
> >
> > 1 -------------------------------------------------------------------------------
> > 2 Test set: org.apache.tika.parser.grib.GribParserTest
> > 3 -------------------------------------------------------------------------------
> > 4 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.076 sec <<< FAILURE!
> > 5 testParseGlobalMetadata(org.apache.tika.parser.grib.GribParserTest) Time elapsed: 0.075 sec <<< ERROR!
> > 6 org.apache.tika.exception.TikaException: NetCDF parse error
> > 7 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:134)
> > 8 at org.apache.tika.parser.grib.GribParserTest.testParseGlobalMetadata(GribParserTest.java:52)
> > 9 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > 10 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > 11 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > 12 at java.lang.reflect.Method.invoke(Method.java:606)
> > 13 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > 14 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > 15 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > 16 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> > 17 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > 18 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > 19 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > 20 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > 21 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > 22 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > 23 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > 24 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > 25 at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > 26 at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > 27 at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > 28 at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > 29 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > 30 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > 31 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > 32 at java.lang.reflect.Method.invoke(Method.java:606)
> > 33 at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > 34 at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > 35 at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > 36 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > 37 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > 38 Caused by: java.io.IOException: Cant read gdas1.forecmwf.2014062612.grib2: not a valid CDM file.
> > 39 at ucar.nc2.NetcdfFile.open(NetcdfFile.java:803)
> > 40 at ucar.nc2.NetcdfFile.openInMemory(NetcdfFile.java:719)
> > 41 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:86)
> > 42 ... 30 more
> >
> > We need to do more work here, also there are a number of issue which need to be addressed and carried over from th previous issue I feel.
>
> Vineet Ghatge Hemantkumar wrote:
> I will see why its failing.
>
> Vineet Ghatge Hemantkumar wrote:
> In the patch, I see that metadata.set(Metadata.RESOURCE_NAME_KEY, "gdas1.forecmwf.2014062612.grib2"); this shoudl be the following
> metadata.set(Metadata.RESOURCE_NAME_KEY, "/test-documents/gdas1.forecmwf.2014062612.grib2");
Further, I am using the netcdfall 4.5 jar which is not what is there in repo, When I run from command line using the following coommand
javac -cp .:netcdfAll-4.5.jar:tika-app-1.7-SNAPSHOT.jar:junit-4.11.jar Grib.java, java -cp .:netcdfAll-4.5.jar:tika-app-1.7-SNAPSHOT.jar:junit-4.11.jar Grib it works. I am trying rebuild in tika
- Vineet Ghatge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review59734
-----------------------------------------------------------
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Vineet Ghatge Hemantkumar <he...@usc.edu>.
> On Nov. 4, 2014, 5:45 a.m., Lewis McGibbney wrote:
> > OK, test is also failing for me with Tika trunk as follows
> >
> > 1 -------------------------------------------------------------------------------
> > 2 Test set: org.apache.tika.parser.grib.GribParserTest
> > 3 -------------------------------------------------------------------------------
> > 4 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.076 sec <<< FAILURE!
> > 5 testParseGlobalMetadata(org.apache.tika.parser.grib.GribParserTest) Time elapsed: 0.075 sec <<< ERROR!
> > 6 org.apache.tika.exception.TikaException: NetCDF parse error
> > 7 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:134)
> > 8 at org.apache.tika.parser.grib.GribParserTest.testParseGlobalMetadata(GribParserTest.java:52)
> > 9 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > 10 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > 11 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > 12 at java.lang.reflect.Method.invoke(Method.java:606)
> > 13 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> > 14 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> > 15 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> > 16 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> > 17 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> > 18 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> > 19 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> > 20 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> > 21 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> > 22 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> > 23 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> > 24 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> > 25 at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> > 26 at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
> > 27 at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
> > 28 at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
> > 29 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> > 30 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> > 31 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> > 32 at java.lang.reflect.Method.invoke(Method.java:606)
> > 33 at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
> > 34 at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
> > 35 at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
> > 36 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
> > 37 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
> > 38 Caused by: java.io.IOException: Cant read gdas1.forecmwf.2014062612.grib2: not a valid CDM file.
> > 39 at ucar.nc2.NetcdfFile.open(NetcdfFile.java:803)
> > 40 at ucar.nc2.NetcdfFile.openInMemory(NetcdfFile.java:719)
> > 41 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:86)
> > 42 ... 30 more
> >
> > We need to do more work here, also there are a number of issue which need to be addressed and carried over from th previous issue I feel.
>
> Vineet Ghatge Hemantkumar wrote:
> I will see why its failing.
>
> Vineet Ghatge Hemantkumar wrote:
> In the patch, I see that metadata.set(Metadata.RESOURCE_NAME_KEY, "gdas1.forecmwf.2014062612.grib2"); this shoudl be the following
> metadata.set(Metadata.RESOURCE_NAME_KEY, "/test-documents/gdas1.forecmwf.2014062612.grib2");
>
> Vineet Ghatge Hemantkumar wrote:
> Further, I am using the netcdfall 4.5 jar which is not what is there in repo, When I run from command line using the following coommand
> javac -cp .:netcdfAll-4.5.jar:tika-app-1.7-SNAPSHOT.jar:junit-4.11.jar Grib.java, java -cp .:netcdfAll-4.5.jar:tika-app-1.7-SNAPSHOT.jar:junit-4.11.jar Grib it works. I am trying rebuild in tika
I am trying to apply the patch and it keeps erroring out that this not a valid patch?
- Vineet Ghatge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review59734
-----------------------------------------------------------
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Lewis McGibbney <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review59734
-----------------------------------------------------------
OK, test is also failing for me with Tika trunk as follows
1 -------------------------------------------------------------------------------
2 Test set: org.apache.tika.parser.grib.GribParserTest
3 -------------------------------------------------------------------------------
4 Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.076 sec <<< FAILURE!
5 testParseGlobalMetadata(org.apache.tika.parser.grib.GribParserTest) Time elapsed: 0.075 sec <<< ERROR!
6 org.apache.tika.exception.TikaException: NetCDF parse error
7 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:134)
8 at org.apache.tika.parser.grib.GribParserTest.testParseGlobalMetadata(GribParserTest.java:52)
9 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
10 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
11 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
12 at java.lang.reflect.Method.invoke(Method.java:606)
13 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
14 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
15 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
16 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
17 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
18 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
19 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
20 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
21 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
22 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
23 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
24 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
25 at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
26 at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236)
27 at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134)
28 at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113)
29 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
30 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
31 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
32 at java.lang.reflect.Method.invoke(Method.java:606)
33 at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
34 at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
35 at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
36 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103)
37 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74)
38 Caused by: java.io.IOException: Cant read gdas1.forecmwf.2014062612.grib2: not a valid CDM file.
39 at ucar.nc2.NetcdfFile.open(NetcdfFile.java:803)
40 at ucar.nc2.NetcdfFile.openInMemory(NetcdfFile.java:719)
41 at org.apache.tika.parser.grib.GribParser.parse(GribParser.java:86)
42 ... 30 more
We need to do more work here, also there are a number of issue which need to be addressed and carried over from th previous issue I feel.
- Lewis McGibbney
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Vineet Ghatge Hemantkumar <he...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review60025
-----------------------------------------------------------
Updating the patch
- Vineet Ghatge Hemantkumar
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Lewis McGibbney <le...@apache.org>.
> On Nov. 4, 2014, 5:23 a.m., Lewis McGibbney wrote:
> > Patch is looking good. I am testing
>
> Vineet Ghatge Hemantkumar wrote:
> Yes @mattmann, the unit test passes for me
what is the grib file please? Where can I find it?
- Lewis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review59728
-----------------------------------------------------------
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Vineet Ghatge Hemantkumar <he...@usc.edu>.
> On Nov. 4, 2014, 5:23 a.m., Lewis McGibbney wrote:
> > Patch is looking good. I am testing
Yes @mattmann, the unit test passes for me
- Vineet Ghatge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review59728
-----------------------------------------------------------
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Vineet Ghatge Hemantkumar <he...@usc.edu>.
> On Nov. 4, 2014, 5:23 a.m., Lewis McGibbney wrote:
> > Patch is looking good. I am testing
>
> Vineet Ghatge Hemantkumar wrote:
> Yes @mattmann, the unit test passes for me
>
> Lewis McGibbney wrote:
> what is the grib file please? Where can I find it?
This is the grib file - gdas1.forecmwf.2014062612.grib2 and this is under the following location
./trunk/tika-parsers/src/test/resources/test-documents/
- Vineet Ghatge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review59728
-----------------------------------------------------------
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Lewis McGibbney <le...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/#review59728
-----------------------------------------------------------
Patch is looking good. I am testing
- Lewis McGibbney
On Nov. 4, 2014, 5:17 a.m., Chris Mattmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27562/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2014, 5:17 a.m.)
>
>
> Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
>
>
> Bugs: tika-1423
> https://issues.apache.org/jira/browse/tika-1423
>
>
> Repository: tika
>
>
> Description
> -------
>
> GRIB Parser Patch
>
>
> Diffs
> -----
>
> ./trunk/tika-parsers/pom.xml 1636144
> ./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
> ./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
> ./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
> ./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
>
> Diff: https://reviews.apache.org/r/27562/diff/
>
>
> Testing
> -------
>
> update for #27414
>
> FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
> Patch is fully up to date with trunk and compiles at least.
>
>
> Thanks,
>
> Chris Mattmann
>
>
Re: Review Request 27562: GRIB Parser for TIKA
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27562/
-----------------------------------------------------------
(Updated Nov. 4, 2014, 5:17 a.m.)
Review request for tika, Lewis McGibbney, Chris Mattmann, Tyler Palsulich, and Vineet Ghatge Hemantkumar.
Bugs: tika-1423
https://issues.apache.org/jira/browse/tika-1423
Repository: tika
Description
-------
GRIB Parser Patch
Diffs
-----
./trunk/tika-parsers/pom.xml 1636144
./trunk/tika-parsers/src/main/java/org/apache/tika/parser/grib/GribParser.java PRE-CREATION
./trunk/tika-parsers/src/main/resources/META-INF/services/org.apache.tika.parser.Parser 1636144
./trunk/tika-parsers/src/test/java/org/apache/tika/parser/grib/GribParserTest.java PRE-CREATION
./trunk/tika-parsers/src/test/resources/test-documents/gdas1.forecmwf.2014062612.grib2 UNKNOWN
Diff: https://reviews.apache.org/r/27562/diff/
Testing (updated)
-------
update for #27414
FYI for the life of me, I can't get the unit test to pass (was this working for you @Vinegh?)
Patch is fully up to date with trunk and compiles at least.
Thanks,
Chris Mattmann