You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2013/10/24 03:43:55 UTC
Review Request 14898: Patch for KAFKA-1060
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14898/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1060
https://issues.apache.org/jira/browse/KAFKA-1060
Repository: kafka
Description
-------
KAFKA-1060.v1
Diffs
-----
core/src/main/scala/kafka/network/RequestChannel.scala 77d7ec034d8534c0d3aef49e9516b9b853c99cb2
core/src/main/scala/kafka/network/SocketServer.scala 216245deb119c8f5e8710b25d5093c456398c568
Diff: https://reviews.apache.org/r/14898/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 14898: Patch for KAFKA-1060
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14898/#review27615
-----------------------------------------------------------
core/src/main/scala/kafka/network/RequestChannel.scala
<https://reviews.apache.org/r/14898/#comment53646>
We should rename dequeueTimeMs to requestDequeueTimeMs.
core/src/main/scala/kafka/network/RequestChannel.scala
<https://reviews.apache.org/r/14898/#comment53645>
We should rename queueTime to requestQueueTime.
core/src/main/scala/kafka/network/RequestChannel.scala
<https://reviews.apache.org/r/14898/#comment53644>
We probably should rename this to RequestQueueTimeMs.
- Jun Rao
On Oct. 27, 2013, 1:45 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14898/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2013, 1:45 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1060
> https://issues.apache.org/jira/browse/KAFKA-1060
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1060.v2
>
>
> KAFKA-1060.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/network/RequestChannel.scala 77d7ec034d8534c0d3aef49e9516b9b853c99cb2
>
> Diff: https://reviews.apache.org/r/14898/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 14898: Small bug fix
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14898/#review27837
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Oct. 29, 2013, 6:12 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14898/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2013, 6:12 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1060
> https://issues.apache.org/jira/browse/KAFKA-1060
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1060.v3.1
>
>
> KAFKA-1060.v3
>
>
> KAFKA-1060.v2
>
>
> KAFKA-1060.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/network/RequestChannel.scala 77d7ec034d8534c0d3aef49e9516b9b853c99cb2
> core/src/main/scala/kafka/server/KafkaRequestHandler.scala 6d562c213b0f55d70341f9d657a7d0c8b212338e
>
> Diff: https://reviews.apache.org/r/14898/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 14898: Small bug fix
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14898/
-----------------------------------------------------------
(Updated Oct. 29, 2013, 6:12 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Small bug fix
Bugs: KAFKA-1060
https://issues.apache.org/jira/browse/KAFKA-1060
Repository: kafka
Description (updated)
-------
KAFKA-1060.v3.1
KAFKA-1060.v3
KAFKA-1060.v2
KAFKA-1060.v1
Diffs (updated)
-----
core/src/main/scala/kafka/network/RequestChannel.scala 77d7ec034d8534c0d3aef49e9516b9b853c99cb2
core/src/main/scala/kafka/server/KafkaRequestHandler.scala 6d562c213b0f55d70341f9d657a7d0c8b212338e
Diff: https://reviews.apache.org/r/14898/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 14898: Patch for KAFKA-1060
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14898/#review27694
-----------------------------------------------------------
I got NPEs while running unit tests with this patch on trunk -
[2013-10-29 09:41:14,373] ERROR Uncaught exception in thread 'kafka-processor-59300-1': (kafka.utils.Utils$:103)
java.lang.NullPointerException
at kafka.network.RequestChannel.receiveResponse(RequestChannel.scala:162)
at kafka.network.Processor.processNewResponses(SocketServer.scala:273)
at kafka.network.Processor.run(SocketServer.scala:232)
at java.lang.Thread.run(Thread.java:695)
[2013-10-29 09:41:14,373] ERROR Uncaught exception in thread 'kafka-processor-59300-2': (kafka.utils.Utils$:103)
java.lang.NullPointerException
at kafka.network.RequestChannel.receiveResponse(RequestChannel.scala:162)
at kafka.network.Processor.processNewResponses(SocketServer.scala:273)
at kafka.network.Processor.run(SocketServer.scala:232)
at java.lang.Thread.run(Thread.java:695)
- Neha Narkhede
On Oct. 28, 2013, 5:52 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14898/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2013, 5:52 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1060
> https://issues.apache.org/jira/browse/KAFKA-1060
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1060.v3
>
>
> KAFKA-1060.v2
>
>
> KAFKA-1060.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/network/RequestChannel.scala 77d7ec034d8534c0d3aef49e9516b9b853c99cb2
> core/src/main/scala/kafka/server/KafkaRequestHandler.scala 6d562c213b0f55d70341f9d657a7d0c8b212338e
>
> Diff: https://reviews.apache.org/r/14898/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 14898: Patch for KAFKA-1060
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14898/
-----------------------------------------------------------
(Updated Oct. 28, 2013, 5:52 p.m.)
Review request for kafka.
Bugs: KAFKA-1060
https://issues.apache.org/jira/browse/KAFKA-1060
Repository: kafka
Description (updated)
-------
KAFKA-1060.v3
KAFKA-1060.v2
KAFKA-1060.v1
Diffs (updated)
-----
core/src/main/scala/kafka/network/RequestChannel.scala 77d7ec034d8534c0d3aef49e9516b9b853c99cb2
core/src/main/scala/kafka/server/KafkaRequestHandler.scala 6d562c213b0f55d70341f9d657a7d0c8b212338e
Diff: https://reviews.apache.org/r/14898/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 14898: Patch for KAFKA-1060
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14898/#review27613
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Oct. 27, 2013, 1:45 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14898/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2013, 1:45 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1060
> https://issues.apache.org/jira/browse/KAFKA-1060
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1060.v2
>
>
> KAFKA-1060.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/network/RequestChannel.scala 77d7ec034d8534c0d3aef49e9516b9b853c99cb2
>
> Diff: https://reviews.apache.org/r/14898/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 14898: Patch for KAFKA-1060
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14898/
-----------------------------------------------------------
(Updated Oct. 27, 2013, 1:45 a.m.)
Review request for kafka.
Bugs: KAFKA-1060
https://issues.apache.org/jira/browse/KAFKA-1060
Repository: kafka
Description (updated)
-------
KAFKA-1060.v2
KAFKA-1060.v1
Diffs (updated)
-----
core/src/main/scala/kafka/network/RequestChannel.scala 77d7ec034d8534c0d3aef49e9516b9b853c99cb2
Diff: https://reviews.apache.org/r/14898/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 14898: Patch for KAFKA-1060
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14898/#review27460
-----------------------------------------------------------
core/src/main/scala/kafka/network/SocketServer.scala
<https://reviews.apache.org/r/14898/#comment53373>
Wouldn't it be better if this is done inside requestChannel.receiveResponse()?
- Jun Rao
On Oct. 24, 2013, 1:43 a.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14898/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2013, 1:43 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1060
> https://issues.apache.org/jira/browse/KAFKA-1060
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1060.v1
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/network/RequestChannel.scala 77d7ec034d8534c0d3aef49e9516b9b853c99cb2
> core/src/main/scala/kafka/network/SocketServer.scala 216245deb119c8f5e8710b25d5093c456398c568
>
> Diff: https://reviews.apache.org/r/14898/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>