You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Eduardo Gambogi Cardoso (JIRA)" <ji...@apache.org> on 2008/08/20 20:38:46 UTC
[jira] Created: (WICKET-1793) Problem with submit
Problem with submit
-------------------
Key: WICKET-1793
URL: https://issues.apache.org/jira/browse/WICKET-1793
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.3.2
Reporter: Eduardo Gambogi Cardoso
Priority: Blocker
Fix For: 1.3.2
When precondition fail, the ajax indicator never gone and i can submit anything until i refresh the browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1793) Problem with submit
Posted by "Eduardo Gambogi Cardoso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624386#action_12624386 ]
Eduardo Gambogi Cardoso commented on WICKET-1793:
-------------------------------------------------
I and Matej found the cause of problem.Its happens when wicket generate inputs tag with id like "id".
> Problem with submit
> -------------------
>
> Key: WICKET-1793
> URL: https://issues.apache.org/jira/browse/WICKET-1793
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Eduardo Gambogi Cardoso
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.2
>
>
> When precondition fail, the ajax indicator never gone and i can submit anything until i refresh the browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-1793) Problem with submit
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624102#action_12624102 ]
knopp edited comment on WICKET-1793 at 8/20/08 12:26 PM:
---------------------------------------------------------------
Actually, the snippet should probably be something more like this
<script type="text/javascript">
Wicket.Ajax.Request.prototype._doGet = Wicket.Ajax.Request.prototype.doGet;
Wicket.Ajax.Request.prototype.doGet = function() {
var res = this._doGet()
if (res == true) {
this.failure();
}
return res;
}
Wicket.Ajax.Request.prototype._doPost = Wicket.Ajax.Request.prototype.doPost;
Wicket.Ajax.Request.prototype.doPost = function(body) {
var res = this._doPost(body)
if (res == true) {
this.failure();
}
return res;
}
</script>
was (Author: knopp):
Actually, the snippet should probably be something more like this
<script type="text/javascript">
Wicket.Ajax.Request.prototype._doGet = Wicket.Ajax.Request.prototype.doGet;
Wicket.Ajax.Request.prototype.doGet = function() {
var res = this._doGet()
if (res == true) {
this.failure();
}
return;
}
Wicket.Ajax.Request.prototype._doPost = Wicket.Ajax.Request.prototype.doPost;
Wicket.Ajax.Request.prototype.doPost = function(body) {
var res = this._doPost(body)
if (res == true) {
this.failure();
}
return;
}
</script>
> Problem with submit
> -------------------
>
> Key: WICKET-1793
> URL: https://issues.apache.org/jira/browse/WICKET-1793
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Eduardo Gambogi Cardoso
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.2
>
>
> When precondition fail, the ajax indicator never gone and i can submit anything until i refresh the browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1793) Problem with submit
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matej Knopp reassigned WICKET-1793:
-----------------------------------
Assignee: Matej Knopp
> Problem with submit
> -------------------
>
> Key: WICKET-1793
> URL: https://issues.apache.org/jira/browse/WICKET-1793
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Eduardo Gambogi Cardoso
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.2
>
>
> When precondition fail, the ajax indicator never gone and i can submit anything until i refresh the browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1793) Problem with submit
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624102#action_12624102 ]
Matej Knopp commented on WICKET-1793:
-------------------------------------
Actually, the snippet should probably be something more like this
<script type="text/javascript">
Wicket.Ajax.Request.prototype._doGet = Wicket.Ajax.Request.prototype.doGet;
Wicket.Ajax.Request.prototype.doGet = function() {
var res = this._doGet()
if (res == true) {
this.failure();
}
return;
}
Wicket.Ajax.Request.prototype._doPost = Wicket.Ajax.Request.prototype.doPost;
Wicket.Ajax.Request.prototype.doPost = function(body) {
var res = this._doPost(body)
if (res == true) {
this.failure();
}
return;
}
</script>
> Problem with submit
> -------------------
>
> Key: WICKET-1793
> URL: https://issues.apache.org/jira/browse/WICKET-1793
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Eduardo Gambogi Cardoso
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.2
>
>
> When precondition fail, the ajax indicator never gone and i can submit anything until i refresh the browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1793) Problem with submit
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624111#action_12624111 ]
Matej Knopp commented on WICKET-1793:
-------------------------------------
Another try
<script type="text/javascript">
Wicket.Ajax.Call.prototype._call = Wicket.Ajax.Call.prototype.call;
Wicket.Ajax.Call.prototype.call = function() {
var res = this._call()
if (res == true) {
Wicket.Ajax.invokePostCallHandlers();
this.successHandler();
}
return res;
}
Wicket.Ajax.Call.prototype._post = Wicket.Ajax.Call.prototype.post;
Wicket.Ajax.Call.prototype.post = function(body) {
var res = this._post(body)
if (res == true) {
Wicket.Ajax.invokePostCallHandlers();
this.successHandler();
}
return res;
}
</script>
> Problem with submit
> -------------------
>
> Key: WICKET-1793
> URL: https://issues.apache.org/jira/browse/WICKET-1793
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Eduardo Gambogi Cardoso
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.2
>
>
> When precondition fail, the ajax indicator never gone and i can submit anything until i refresh the browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1793) Problem with submit
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1793.
-----------------------------------
Resolution: Invalid
> Problem with submit
> -------------------
>
> Key: WICKET-1793
> URL: https://issues.apache.org/jira/browse/WICKET-1793
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Eduardo Gambogi Cardoso
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.5
>
>
> When precondition fail, the ajax indicator never gone and i can submit anything until i refresh the browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1793) Problem with submit
Posted by "Matej Knopp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624089#action_12624089 ]
Matej Knopp commented on WICKET-1793:
-------------------------------------
I don't think the we should invoke failure handler when precondition fails, because we don't invoke before handlers either.
Something like this might fix the issue for you locally
<script type="text/javascript">
Wicket.Ajax.Request.prototype._done = Wicket.Ajax.Request.prototype.done;
Wicket.Ajax.Request.prototype.done = function() {
this.failure();
this._done();
}
</script>
> Problem with submit
> -------------------
>
> Key: WICKET-1793
> URL: https://issues.apache.org/jira/browse/WICKET-1793
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Eduardo Gambogi Cardoso
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.2
>
>
> When precondition fail, the ajax indicator never gone and i can submit anything until i refresh the browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1793) Problem with submit
Posted by "Martijn Dashorst (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn Dashorst updated WICKET-1793:
-------------------------------------
Fix Version/s: (was: 1.3.2)
1.3.5
> Problem with submit
> -------------------
>
> Key: WICKET-1793
> URL: https://issues.apache.org/jira/browse/WICKET-1793
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.2
> Reporter: Eduardo Gambogi Cardoso
> Assignee: Matej Knopp
> Priority: Blocker
> Fix For: 1.3.5
>
>
> When precondition fail, the ajax indicator never gone and i can submit anything until i refresh the browser
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.