[GitHub] [daffodil] stevedlawrence opened a new pull request #620: Improve path expression error handling

[GitBox <gi...@apache.org>]

stevedlawrence opened a new pull request #620:
URL: https://github.com/apache/daffodil/pull/620


   - The context of a dfdl:occursCountKind expression evaluation is
     actually not the element that the property lives on, but on the
     elements parent. This is because the element isn't created until the
     number of occurrences are known. This means that such expressions must
     either be absolute, or start with an ".." upward move. We previously
     had an assertion that checked this, but there's nothing actually
     preventing expressions without upward moves. This assertion is instead
     changed to an SDE.
   - The conversions for path expressions were applied only on the last
     downward step. But this meant that if an expression path was made up
     of only upward steps, no conversions would occur. Such expressions are
     rarely reasonable, but are legal, and should usually result in an
     error. But because no conversions happened, where certain types of
     error checks occur, it meant it was possible to miss certain
     compile-time convertability checks, allowing for expressions to fail
     at runtime with a NullPointerExceptions. This modifies conversions to
     be applied to the entire path, instead of on the last downward step.
     This doesn't change what conversions are applied, only ensures that
     they are always applied.
   - Additional refactorings related to path steps to make it a little more
     clear what's going on.
   
   DAFFODIL-2553


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence merged pull request #620: Improve path expression error handling

[GitBox <gi...@apache.org>]

stevedlawrence merged pull request #620:
URL: https://github.com/apache/daffodil/pull/620


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org