You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jacob Champion <ch...@gmail.com> on 2017/03/01 17:21:59 UTC
Re: svn commit: r1784990 - in /httpd/httpd/branches/2.4.x: ./
modules/lua/
On 03/01/2017 08:54 AM, jim@apache.org wrote:
> Author: jim
> Date: Wed Mar 1 16:54:35 2017
> New Revision: 1784990
>
> URL: http://svn.apache.org/viewvc?rev=1784990&view=rev
> Log:
> Backport of Lua exhancements from trunk, mostly to support 5.3
In case it helps with the 5.3 effort: configure is not currently looking
in the correct "lua5.3" flavor of include directories. I have a set of
two patches up [1, 2] but I haven't checked them in yet because...
> Modified: httpd/httpd/branches/2.4.x/modules/lua/NWGNUmakefile
> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/lua/NWGNUmakefile?rev=1784990&r1=1784989&r2=1784990&view=diff
> ==============================================================================
> --- httpd/httpd/branches/2.4.x/modules/lua/NWGNUmakefile (original)
> +++ httpd/httpd/branches/2.4.x/modules/lua/NWGNUmakefile Wed Mar 1 16:54:35 2017
> @@ -46,6 +46,9 @@ XCFLAGS += \
> #
> XDEFINES += \
> -DLUA_COMPAT_ALL \
> + -DLUA_COMPAT_5_2 \
> + -DLUA_COMPAT_5_1 \
> + -DLUA_COMPAT_MODULE \
> $(EOLIST)
...this doesn't help with compilation against Debian-distributed Lua
5.3, because they've stopped enabling the deprecated compatibility APIs.
I don't remember the exact APIs right now, but I pinged Daniel about it
a couple weeks ago, so he might. :D
--Jacob
[1] https://github.com/jchampio/httpd/commit/3d5e915f
[2] https://github.com/jchampio/httpd/commit/eef76e90
Re: svn commit: r1784990 - in /httpd/httpd/branches/2.4.x: ./
modules/lua/
Posted by Jacob Champion <ch...@gmail.com>.
On 03/01/2017 12:46 PM, Jim Jagielski wrote:
> I think it's also safe to adjust to keep the "Looking for" 5.1 -> 5.2
> to also add 5.3 explicitly
Yep, that's what my two patches do. I haven't checked them in because
they break the build on Ubuntu.
--Jacob
Re: svn commit: r1784990 - in /httpd/httpd/branches/2.4.x: ./
modules/lua/
Posted by Jim Jagielski <ji...@jaguNET.com>.
I think it's also safe to adjust to keep the "Looking for" 5.1 -> 5.2
to also add 5.3 explicitly
> On Mar 1, 2017, at 1:36 PM, Jacob Champion <ch...@gmail.com> wrote:
>
> On 03/01/2017 09:44 AM, Jim Jagielski wrote:
>> Hmmm... WFM under macOS and fedora and centos.
>
> Cool. I assume they're using an undecorated "liblua"? Debian ships a differently-named library for each version... not sure why.
>
> (To be clear, this isn't a -1 on the backport or anything, just a note that 5.3 support isn't complete for the Debuntu crew.)
>
> --Jacob
>
Re: svn commit: r1784990 - in /httpd/httpd/branches/2.4.x: ./
modules/lua/
Posted by Jacob Champion <ch...@gmail.com>.
On 03/01/2017 09:44 AM, Jim Jagielski wrote:
> Hmmm... WFM under macOS and fedora and centos.
Cool. I assume they're using an undecorated "liblua"? Debian ships a
differently-named library for each version... not sure why.
(To be clear, this isn't a -1 on the backport or anything, just a note
that 5.3 support isn't complete for the Debuntu crew.)
--Jacob
Re: svn commit: r1784990 - in /httpd/httpd/branches/2.4.x: ./
modules/lua/
Posted by Jim Jagielski <ji...@jaguNET.com>.
Hmmm... WFM under macOS and fedora and centos.
> On Mar 1, 2017, at 12:21 PM, Jacob Champion <ch...@gmail.com> wrote:
>
> On 03/01/2017 08:54 AM, jim@apache.org wrote:
>> Author: jim
>> Date: Wed Mar 1 16:54:35 2017
>> New Revision: 1784990
>>
>> URL: http://svn.apache.org/viewvc?rev=1784990&view=rev
>> Log:
>> Backport of Lua exhancements from trunk, mostly to support 5.3
>
> In case it helps with the 5.3 effort: configure is not currently looking in the correct "lua5.3" flavor of include directories. I have a set of two patches up [1, 2] but I haven't checked them in yet because...
>
>> Modified: httpd/httpd/branches/2.4.x/modules/lua/NWGNUmakefile
>> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/lua/NWGNUmakefile?rev=1784990&r1=1784989&r2=1784990&view=diff
>> ==============================================================================
>> --- httpd/httpd/branches/2.4.x/modules/lua/NWGNUmakefile (original)
>> +++ httpd/httpd/branches/2.4.x/modules/lua/NWGNUmakefile Wed Mar 1 16:54:35 2017
>> @@ -46,6 +46,9 @@ XCFLAGS += \
>> #
>> XDEFINES += \
>> -DLUA_COMPAT_ALL \
>> + -DLUA_COMPAT_5_2 \
>> + -DLUA_COMPAT_5_1 \
>> + -DLUA_COMPAT_MODULE \
>> $(EOLIST)
>
> ...this doesn't help with compilation against Debian-distributed Lua 5.3, because they've stopped enabling the deprecated compatibility APIs. I don't remember the exact APIs right now, but I pinged Daniel about it a couple weeks ago, so he might. :D
>
> --Jacob
>
> [1] https://github.com/jchampio/httpd/commit/3d5e915f
> [2] https://github.com/jchampio/httpd/commit/eef76e90