You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/05/05 12:54:20 UTC
[GitHub] [solr] risdenk opened a new pull request, #837: SOLR-16182: CloudSolrClientBuilderTest thread leak - close ZkClientClusterStateProvider
risdenk opened a new pull request, #837:
URL: https://github.com/apache/solr/pull/837
https://issues.apache.org/jira/browse/SOLR-16182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #837: SOLR-16182: Close ZkClientClusterStateProvider in tests to avoid thread leak
Posted by GitBox <gi...@apache.org>.
risdenk merged PR #837:
URL: https://github.com/apache/solr/pull/837
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #837: SOLR-16182: Close ZkClientClusterStateProvider in tests to avoid thread leak
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #837:
URL: https://github.com/apache/solr/pull/837#issuecomment-1118552500
@magibney thanks updated the PR and jira to address all of the same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] magibney commented on pull request #837: SOLR-16182: CloudSolrClientBuilderTest thread leak - close ZkClientClusterStateProvider
Posted by GitBox <gi...@apache.org>.
magibney commented on PR #837:
URL: https://github.com/apache/solr/pull/837#issuecomment-1118535359
Nice! I think there are other instances of this pattern that could probably be cleaned up in the same way. I checked a handful of these against the builds@solr mailing list search link you posted in the Jira and they seem to manifest similar errors:
```
> find solr -name '*.java' | xargs grep -l 'ZkClientClusterStateProvider\.from('
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientMultiConstructorTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientBuilderTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientBuilderTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrClientTest.java
solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudHttp2SolrClientMultiConstructorTest.java
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #837: SOLR-16182: CloudSolrClientBuilderTest thread leak - close ZkClientClusterStateProvider
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #837:
URL: https://github.com/apache/solr/pull/837#issuecomment-1118536280
@magibney yup agreed - was looking at CloudHttp2SolrClientMultiConstructorTest next actually since I figured it was a similar problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org