You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2021/12/06 15:16:32 UTC
[GitHub] [drill] kingswanwho opened a new pull request #2395: [DRILL-8067] Localize the font for better User-experience of China mainland
kingswanwho opened a new pull request #2395:
URL: https://github.com/apache/drill/pull/2395
# [DRILL-8067](https://issues.apache.org/jira/browse/DRILL-8067): Localize the font for better User-experience of China mainland
## Description
Drill Web UI requests a font to Google's URL https://fonts.googleapis.com/icon?family=Material+Icons,
since users from China mainland cannot visit google directly, each Drill Web UI will render until the request time-out, to make the Web UI works slowly.
This PR deleted the request and localized the font to make render faster for China mainland user.
## Documentation
N/A
## Testing
(Please describe how this PR has been tested.)
Web UI doesn't request font to google, and the render get faster obviously.
Manually tested Drill Web UI basic functions:
Query, Profiles, Storage, Metrics, Threads, Logs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] cgivre merged pull request #2395: DRILL-8067: Localize the font for better User-experience of China mainland
Posted by GitBox <gi...@apache.org>.
cgivre merged pull request #2395:
URL: https://github.com/apache/drill/pull/2395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on a change in pull request #2395: [DRILL-8067] Localize the font for better User-experience of China mainland
Posted by GitBox <gi...@apache.org>.
vdiravka commented on a change in pull request #2395:
URL: https://github.com/apache/drill/pull/2395#discussion_r764667955
##########
File path: exec/java-exec/src/main/resources/rest/static/css/drillStyle.css
##########
@@ -7,3 +7,27 @@ body {
.close {
outline: none;
}
+
+/* Material + Icons */
+@font-face {
+ font-family: 'Material Icons';
+ font-style: normal;
+ font-weight: 400;
+ src: url('materialicons_v118.woff2') format('woff2');
+}
+
+.material-icons {
+ font-family: 'Material Icons';
+ font-weight: normal;
+ font-style: normal;
+ font-size: 24px;
+ line-height: 1;
+ letter-spacing: normal;
+ text-transform: none;
+ display: inline-block;
+ white-space: nowrap;
+ word-wrap: normal;
+ direction: ltr;
+ -webkit-font-feature-settings: 'liga';
+ -webkit-font-smoothing: antialiased;
+}
Review comment:
```suggestion
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] dzamo commented on pull request #2395: [DRILL-8067] Localize the font for better User-experience of China mainland
Posted by GitBox <gi...@apache.org>.
dzamo commented on pull request #2395:
URL: https://github.com/apache/drill/pull/2395#issuecomment-986900565
I just checked and the Material Design Icons are under the Apache license, so no problem there. LGTM, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org