[GitHub] [incubator-yunikorn-core] wilfred-s commented on pull request #298: YUNIKORN-792 Refactor sorting_policy.go

[GitBox <gi...@apache.org>]

wilfred-s commented on pull request #298:
URL: https://github.com/apache/incubator-yunikorn-core/pull/298#issuecomment-898177440


   I don't think this is a good idea at the moment. We need to finish the template first at that point we need to look at this.
   We probably also want to go one step further:
   * make a split between queue and application sorting at this time
   * rename SortPolicy to ApplicationSorter (policy is implied) and give queue its own
   * use an interface like implementation as we do for the node sorting.
   * make Undefined the first value in the iota (default remains the Undefined value)
   * update the way we process the policy and remove the need to call it from the partition for the root queue
   * remove logging of unknown properties completely
   
   Keeping Undefined as it will allow a next step, after this refactor, to specify a partition wide default in the config which we do not have as it is hard coded to Fair. The move of Undefined to the first entry also opens up an easier extension of types (like priority which has been talked about for a long time).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org