You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/08/22 17:18:09 UTC
Review Request 61818: Adjusted a comment and a log message around
container termination.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61818/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Ian Downes, and Jie Yu.
Repository: mesos
Description
-------
When the container launch is aborted and the container is
cleaned up in the containerizer before `executorLaunched()` is
invoked, `containerizer->wait()` called in `executorLaunched()`
does not hold a termination object. This case should not be
logged as an error.
Diffs
-----
src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
Diff: https://reviews.apache.org/r/61818/diff/1/
Testing
-------
None: not a functional change.
Thanks,
Alexander Rukletsov
Re: Review Request 61818: Adjusted a comment and a log message around
container termination.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61818/#review183635
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61811, 59746, 61818]
Logs available here: http://104.210.40.105/logs/master/61818
- Mesos Reviewbot Windows
On Aug. 22, 2017, 5:18 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61818/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 5:18 p.m.)
>
>
> Review request for mesos, Gilbert Song, Ian Downes, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When the container launch is aborted and the container is
> cleaned up in the containerizer before `executorLaunched()` is
> invoked, `containerizer->wait()` called in `executorLaunched()`
> does not hold a termination object. This case should not be
> logged as an error.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/61818/diff/1/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 61818: Adjusted a comment and a log message around
container termination.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61818/#review183599
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61811, 59746, 61818]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 22, 2017, 5:18 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61818/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2017, 5:18 p.m.)
>
>
> Review request for mesos, Gilbert Song, Ian Downes, and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When the container launch is aborted and the container is
> cleaned up in the containerizer before `executorLaunched()` is
> invoked, `containerizer->wait()` called in `executorLaunched()`
> does not hold a termination object. This case should not be
> logged as an error.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a
>
>
> Diff: https://reviews.apache.org/r/61818/diff/1/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Alexander Rukletsov
>
>