You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/04/25 00:11:00 UTC
[kudu-CR] build-and-test.sh: add PIP FLAGS
Hello Andrew Wong,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/13110
to review the following change.
Change subject: build-and-test.sh: add PIP_FLAGS
......................................................................
build-and-test.sh: add PIP_FLAGS
We want to control pip's caching behavior using --cache-dir and
--no-cache-dir. Importantly, these are _pip_ flags and not _pip install_
flags, so we must introduce a new environment variable to pass them in.
Change-Id: I98c0418debbf706df32479bb47e68aece903e106
---
M build-support/jenkins/build-and-test.sh
1 file changed, 16 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/13110/1
--
To view, visit http://gerrit.cloudera.org:8080/13110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] build-and-test.sh: add PIP FLAGS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13110 )
Change subject: build-and-test.sh: add PIP_FLAGS
......................................................................
Patch Set 1: Code-Review+2
Have you tested this yet end-to-end with --no-cache-dir?
--
To view, visit http://gerrit.cloudera.org:8080/13110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Apr 2019 00:22:43 +0000
Gerrit-HasComments: No
[kudu-CR] build-and-test.sh: add PIP FLAGS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13110 )
Change subject: build-and-test.sh: add PIP_FLAGS
......................................................................
Patch Set 2:
> Patch Set 1: Code-Review+2
>
> Have you tested this yet end-to-end with --no-cache-dir?
The kudu-gerrit job configuration now contains this:
export PIP_FLAGS="--no-cache-dir"
And PS1 failed with:
17:20:27 Usage:
17:20:27 pip <command> [options]
17:20:27
17:20:27 no such option: --no-cache-dir
Now trying a slightly different approach.
--
To view, visit http://gerrit.cloudera.org:8080/13110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Apr 2019 00:38:58 +0000
Gerrit-HasComments: No
[kudu-CR] build-and-test.sh: add PIP FLAGS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/13110 )
Change subject: build-and-test.sh: add PIP_FLAGS
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/13110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] build-and-test.sh: add PIP FLAGS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13110 )
Change subject: build-and-test.sh: add PIP_FLAGS
......................................................................
build-and-test.sh: add PIP_FLAGS
We want to control pip's caching behavior using --cache-dir and
--no-cache-dir. Importantly, these are _pip_ flags and not _pip install_
flags, so we must introduce a new environment variable to pass them in.
Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Reviewed-on: http://gerrit.cloudera.org:8080/13110
Tested-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 20 insertions(+), 9 deletions(-)
Approvals:
Adar Dembo: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] build-and-test.sh: add PIP FLAGS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13110 )
Change subject: build-and-test.sh: add PIP_FLAGS
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13110/2/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/13110/2/build-support/jenkins/build-and-test.sh@592
PS2, Line 592: # The absence of $PIP_FLAGS is intentional: older versions of pip may not
: # support the flags that we want to use.
> This is OK because so far, we've had difficulties when installing specific
Yes. The main issue is when installing a package involves compiling some native code (i.e. pandas). pip doesn't have that requirement, so the fact that it's cached doesn't really matter.
I mean, in in ideal world we wouldn't cache it at all. But if the original pip version doesn't support --no-cache-dir, there's not much we can do.
--
To view, visit http://gerrit.cloudera.org:8080/13110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 03:46:10 +0000
Gerrit-HasComments: Yes
[kudu-CR] build-and-test.sh: add PIP FLAGS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13110
to look at the new patch set (#2).
Change subject: build-and-test.sh: add PIP_FLAGS
......................................................................
build-and-test.sh: add PIP_FLAGS
We want to control pip's caching behavior using --cache-dir and
--no-cache-dir. Importantly, these are _pip_ flags and not _pip install_
flags, so we must introduce a new environment variable to pass them in.
Change-Id: I98c0418debbf706df32479bb47e68aece903e106
---
M build-support/jenkins/build-and-test.sh
1 file changed, 20 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/13110/2
--
To view, visit http://gerrit.cloudera.org:8080/13110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] build-and-test.sh: add PIP FLAGS
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13110 )
Change subject: build-and-test.sh: add PIP_FLAGS
......................................................................
Patch Set 2: Verified+1
Overriding Jenkins, flaky test.
--
To view, visit http://gerrit.cloudera.org:8080/13110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 25 Apr 2019 00:58:19 +0000
Gerrit-HasComments: No
[kudu-CR] build-and-test.sh: add PIP FLAGS
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13110 )
Change subject: build-and-test.sh: add PIP_FLAGS
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13110/2/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:
http://gerrit.cloudera.org:8080/#/c/13110/2/build-support/jenkins/build-and-test.sh@592
PS2, Line 592: # The absence of $PIP_FLAGS is intentional: older versions of pip may not
: # support the flags that we want to use.
This is OK because so far, we've had difficulties when installing specific packages, not pip itself, right? And presumably upgrading pip, even with caching, should always do the right thing (TM)?
--
To view, visit http://gerrit.cloudera.org:8080/13110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98c0418debbf706df32479bb47e68aece903e106
Gerrit-Change-Number: 13110
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Apr 2019 01:29:32 +0000
Gerrit-HasComments: Yes