You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by NicoK <gi...@git.apache.org> on 2017/08/22 08:22:46 UTC
[GitHub] flink pull request #4571: [FLINK-7487][tests] fix ClassLoaderITCase#testDisp...
GitHub user NicoK opened a pull request:
https://github.com/apache/flink/pull/4571
[FLINK-7487][tests] fix ClassLoaderITCase#testDisposeSavepointWithCustomKvState not self-contained
## What is the purpose of the change
The cancellation of the job started in `ClassLoaderITCase#testDisposeSavepointWithCustomKvState()` may actually continue after the test method succeeds and may thus stop further jobs from being executed. This may result in a `NoResourceAvailableException`.
## Brief change log
- wait for the execution to finish in `ClassLoaderITCase#testDisposeSavepointWithCustomKvState()`
## Verifying this change
This change is fixing a unit test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/NicoK/flink flink-7487
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4571.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4571
----
commit fb32ff1aed2707cdc17bc3e422aa4590b8599a56
Author: Nico Kruber <ni...@data-artisans.com>
Date: 2017-08-21T15:20:30Z
[FLINK-7487][tests] fix ClassLoaderITCase#testDisposeSavepointWithCustomKvState not self-contained
The cancellation of the job started in #testDisposeSavepointWithCustomKvState
may actually continue after the test method succeeds and may thus stop further
jobs from being executed. This may result in a NoResourceAvailableException.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4571: [FLINK-7487][tests] fix ClassLoaderITCase#testDisp...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/4571#discussion_r136814704
--- Diff: flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java ---
@@ -391,5 +391,8 @@ public void run() {
Future<?> cancelFuture = jm.ask(new JobManagerMessages.CancelJob(jobId), deadline.timeLeft());
Object response = Await.result(cancelFuture, deadline.timeLeft());
assertTrue("Unexpected response: " + response, response instanceof JobManagerMessages.CancellationSuccess);
+
+ // make sure, the execution is finished to not influence other test methods
+ invokeThread.join(deadline.timeLeft().toMillis());
--- End diff --
add `assertFalse(invokeThread.isAlive());` ?
---
[GitHub] flink pull request #4571: [FLINK-7487][tests] fix ClassLoaderITCase#testDisp...
Posted by NicoK <gi...@git.apache.org>.
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/4571#discussion_r140235301
--- Diff: flink-tests/src/test/java/org/apache/flink/test/classloading/ClassLoaderITCase.java ---
@@ -391,5 +391,8 @@ public void run() {
Future<?> cancelFuture = jm.ask(new JobManagerMessages.CancelJob(jobId), deadline.timeLeft());
Object response = Await.result(cancelFuture, deadline.timeLeft());
assertTrue("Unexpected response: " + response, response instanceof JobManagerMessages.CancellationSuccess);
+
+ // make sure, the execution is finished to not influence other test methods
+ invokeThread.join(deadline.timeLeft().toMillis());
--- End diff --
makes sense, absolutely
---
[GitHub] flink issue #4571: [FLINK-7487][tests] fix ClassLoaderITCase#testDisposeSave...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4571
Thanks for your contribution @NicoK. Merging this PR.
---
[GitHub] flink pull request #4571: [FLINK-7487][tests] fix ClassLoaderITCase#testDisp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4571
---