[GitHub] [arrow] kou commented on a diff in pull request #34765: GH-14917: [C++] Issues with GTest when building Arrow C++ on MacOS

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #34765:
URL: https://github.com/apache/arrow/pull/34765#discussion_r1151436316


##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -115,6 +115,9 @@ elseif(ARROW_CPU_FLAG STREQUAL "aarch64")
   if(ARROW_SIMD_LEVEL STREQUAL "DEFAULT")
     set(ARROW_SIMD_LEVEL "NEON")
   endif()
+  if(APPLE)
+    set(GTest_SOURCE "BUNDLED")
+  endif()

Review Comment:
   We should not change `*_SOURCE` in `SetupCxxFlags.cmake`.
   We should process `*_SOURCE` in `ThirdpartyToolchain.cmake`.
   
   This problem is caused by C++ standard difference, right?
   For example, this problem is caused when Apache Arrow C++ uses C++17 and system GoogleTest uses C++14.
   
   Can we detect whether system GoogleTest uses different C++ standard than Apache Arrow C++? If we can detect it, we can fallback to bundled GoogleTest automatically when system GoogleTest uses different C++ standard.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org