[jira] Resolved: (THRIFT-114) Isset structure when not using javabeans generator is completely useless

["David Reiss (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-114.
--------------------------------

    Resolution: Invalid

They get set to true by the reader methods to let you know what fields were present.

Please open separate tickets if you want to discuss any of the following.
1/ Unlike in C++, __isset is not respected when writing optional fields.
2/ It is obvious when a non-primitive type was not set.
3/ There is no way to save memory be eliminating __isset when you know you won't need it.

> Isset structure when not using javabeans generator is completely useless
> ------------------------------------------------------------------------
>
>                 Key: THRIFT-114
>                 URL: https://issues.apache.org/jira/browse/THRIFT-114
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (Java)
>            Reporter: Bryan Duxbury
>            Priority: Minor
>
> If you're not using the javabeans generator, then interactions with __isset are completely unnecessary. The only time they are set is in the constructor, and they are only checked in the .equals method. It seems like code generated without javabeans should just omit this structure (and the attendant code) completely.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.